rsx/shaders: Implement a basic CFG and use it for FP decompilation #17743
+763
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also fix pred edge direction bug
- These are just PAND and POR instruction wrappers for SSE2, no idea why they're classified as 'avx512'
|
still broken in build 0.0.38-18396 |
Contributor
Author
#17701 is still not merged. There's going to be several other small PRs before "I am alive" is fully fixed. I'll update the ticket when that happens. |
Will that fix Condemned 2? |
|
@Emogop Ill give it a test once this becomes used, as of now however the game has suffered a regression and doesn’t launch in vulkan so it might be awhile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing should change in games, the goal is to implement some passes, mostly for correctness but we can also do DCE with this.
Primary target is to reimplement register dependency tracking initially attempted in #17701. That functionality will close many otherwise unfixable issues with shader bugs.
Closes #17712