clr: Bump _amdgpu_r_debug.r_version to 11 #2063
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch bumps the CRL's _amdgpu_r_debug.r_version to 11 to follow ROCr. This is also used by the debugger as a baseline to ensure simulated AQL queues are supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This patch bumps the CRL's _amdgpu_r_debug.r_version to 11 to follow ROCr. This is also used by the debugger as a baseline to ensure simulated AQL queues are supported.
Technical Details
Bump the ABI version number exposed to the debugger to match ROCr and give a baseline for debugging support on Winodws.
Test Plan
ROCgdb on windows debugger tests.
Test Result
No regression identified.
Submission Checklist