Skip to content

Commit 0aa044b

Browse files
[rocm-libraries] ROCm/rocm-libraries#712 (commit f741c7a)
=?UTF-8?q?Cherry-pick=20to=20release/rocm-rel-7.0:=20[roc?= =?UTF-8?q?BLAS]=20Docs:=20Change=20GitHub=20links=20and=20install=20guide?= =?UTF-8?q?s=20to=20account=20for=E2=80=A6=20(#712)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit … repo change (#541) This PR makes changes to several guides to point to the rocblas folder in the new rocm-libraries repository. It also updates some install instructions and some other links. I added a note in a few places to refer people using 6.4 or older to the previous rocBLAS repository. (cherry picked from commit 43f328c6d0a96fab1a4b792560220ca3465730df)
1 parent bb7738f commit 0aa044b

File tree

7 files changed

+79
-26
lines changed

7 files changed

+79
-26
lines changed

.github/CONTRIBUTING.rst

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ Contributors wanting to submit new implementations, improvements, or bug fixes
3434
should follow the below mentioned guidelines.
3535

3636
Pull requests will be reviewed by members of
37-
`CODEOWNERS.md <https://github.com/ROCm/rocBLAS/blob/develop/.github/CODEOWNERS>`__
37+
`CODEOWNERS.md <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/.github/CODEOWNERS>`__
3838
Continuous Integration tests will be run on the pull request. Once the pull request
3939
is approved and tests pass it will be merged by a member of
40-
`CODEOWNERS.md <https://github.com/ROCm/rocBLAS/blob/develop/.github/CODEOWNERS>`__.
40+
`CODEOWNERS.md <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/.github/CODEOWNERS>`__.
4141
Attribution for your commit will be preserved when it is merged.
4242

4343

@@ -63,7 +63,7 @@ Pull requests should:
6363
Code License
6464
============
6565
All code contributed to this project will be licensed under the license identified in the
66-
`LICENSE.md <https://github.com/ROCm/rocBLAS/blob/develop/LICENSE.md>`__.
66+
`LICENSE.md <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/LICENSE.md>`__.
6767
Your contribution will be accepted under the same license.
6868

6969
For each new file in repository, please include the licensing header
@@ -250,21 +250,21 @@ Coding Style
250250

251251
#. When tests are added to ``rocblas-test`` and ``rocblas-bench``,
252252
refer to `this
253-
guide <https://github.com/ROCmSoftwarePlatform/rocBLAS/blob/develop/clients/gtest/README.md>`__.
253+
guide <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/clients/gtest/README.md>`__.
254254

255255
The test framework is templated, and uses
256256
SFINAE (substitution failure is not an error) pattern and ``std::enable_if<...>`` to enable and disable certain types for
257257
certain tests.
258258

259259
YAML files are used to describe tests as combinations of arguments.
260-
`rocblas_gentest.py <https://github.com/ROCmSoftwarePlatform/rocBLAS/blob/develop/clients/common/rocblas_gentest.py>`__
260+
`rocblas_gentest.py <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/clients/common/rocblas_gentest.py>`__
261261
is used to parse the YAML files and generate tests in the form of a
262262
binary file of
263-
`Arguments <https://github.com/ROCmSoftwarePlatform/rocBLAS/blob/develop/clients/include/rocblas_arguments.hpp>`__
263+
`Arguments <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/clients/include/rocblas_arguments.hpp>`__
264264
records.
265265

266266
The ``rocblas-test`` and ``rocblas-bench`` `type dispatch
267-
file <https://github.com/ROCmSoftwarePlatform/rocBLAS/blob/develop/clients/include/type_dispatch.hpp>`__
267+
file <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/clients/include/type_dispatch.hpp>`__
268268
is central to all tests. Basically, rather than duplicate:
269269

270270
.. code:: cpp
@@ -280,9 +280,9 @@ Coding Style
280280
template argument is passed to specify which action is actually
281281
taken. It's fairly abstract, but it is powerful. There are examples
282282
of using the type dispatch in
283-
`clients/gtest/*_gtest.cpp <https://github.com/ROCmSoftwarePlatform/rocBLAS/tree/develop/clients/gtest>`__
283+
`clients/gtest/*_gtest.cpp <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/clients/gtest>`__
284284
and
285-
`clients/benchmarks/client.cpp <https://github.com/ROCmSoftwarePlatform/rocBLAS/blob/develop/clients/benchmarks/client.cpp>`__.
285+
`clients/benchmarks/client.cpp <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/clients/benchmarks/client.cpp>`__.
286286

287287
#. Code should not be copied-and pasted, but rather, templates, macros,
288288
SFINAE (substitution failure is not an error) pattern and CRTP (curiously recurring template pattern),
@@ -593,11 +593,11 @@ Coding Style
593593

594594
Note: Some blocked matrix-vector algorithms which call other BLAS
595595
kernels may not work if this simple transformation is used; see
596-
`TRSV <https://github.com/ROCmSoftwarePlatform/rocBLAS/blob/develop/library/src/blas2/rocblas_trsv.cpp>`__
596+
`TRSV <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/library/src/blas2/rocblas_trsv.cpp>`__
597597
for an example, and how it's handled there.
598598

599599
#. For reduction operations, the file
600-
`reduction.hpp <https://github.com/ROCm/rocBLAS/blob/develop/library/src/blas1/reduction.hpp>`
600+
`reduction.hpp <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/library/src/blas1/reduction.hpp>`_
601601
has been created to systematize reductions and perform their device
602602
kernels in one place. This works for ``amax``, ``amin``, ``asum``,
603603
``nrm2``, and (partially) ``dot`` and ``gemv``.

docs/how-to/Contributors_Guide.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ Contributing to rocBLAS
1010

1111
rocBLAS encourages community contributions. For information on how to contribute to the code base,
1212
including information on code review guidelines, coding style, formatting, and
13-
acceptance criteria, see `Contributing to rocBLAS <https://github.com/ROCm/rocBLAS/blob/develop/.github/CONTRIBUTING.rst>`_.
13+
acceptance criteria, see `Contributing to rocBLAS <https://github.com/ROCm/rocm-libraries/blob/develop/projects/rocblas/.github/CONTRIBUTING.rst>`_.

docs/how-to/Programmers_Guide.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ memory allocation, and other technical considerations.
1616
Source code organization
1717
================================
1818

19-
The rocBLAS code can be found at the `rocBLAS GitHub <https://github.com/ROCm/rocBLAS>`_.
19+
The rocBLAS code can be found in the `rocBLAS folder <https://github.com/ROCm/rocm-libraries/tree/develop/projects/rocblas>`_
20+
of the `rocm-libraries GitHub <https://github.com/ROCm/rocm-libraries>`_.
2021
It is split into three major parts:
2122

2223
* The ``library`` directory contains all the source code for the library.

docs/index.rst

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,12 @@ rocBLAS is the ROCm Basic Linear Algebra Subprograms (BLAS) library. rocBLAS is
1212
This documentation set contains instructions for installing, understanding, and using the rocBLAS library.
1313
To learn more, see :doc:`./what-is-rocblas`
1414

15-
The rocBLAS public repository is located at `<https://github.com/ROCm/rocBLAS>`_.
15+
The rocBLAS public repository is located at
16+
`<https://github.com/ROCm/rocm-libraries/tree/develop/projects/rocblas>`_.
17+
18+
.. note::
19+
20+
The rocBLAS repository for ROCm 6.4 and earlier is located at `<https://github.com/ROCm/rocBLAS>`_.
1621

1722
.. grid:: 2
1823
:gutter: 3
@@ -37,7 +42,7 @@ The rocBLAS public repository is located at `<https://github.com/ROCm/rocBLAS>`_
3742

3843
.. grid-item-card:: Examples
3944

40-
* `rocBLAS sample code <https://github.com/ROCm/rocBLAS/tree/develop/clients/samples>`_
45+
* `rocBLAS sample code <https://github.com/ROCm/rocm-libraries/tree/develop/projects/rocblas/clients/samples>`_
4146

4247
.. grid-item-card:: Reference
4348

docs/install/Linux_Install_Guide.rst

Lines changed: 28 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,15 @@ run the following help command:
110110
111111
./install.sh --help
112112
113+
.. note::
114+
115+
You can run the ``install.sh`` script from the ``projects/rocblas`` directory.
116+
113117
Download rocBLAS
114118
----------------
115119

116-
The rocBLAS source code is available at the `rocBLAS GitHub page <https://github.com/ROCm/rocBLAS>`_.
120+
The rocBLAS source code is available from the `rocBLAS folder <https://github.com/ROCm/rocm-libraries/tree/develop/projects/rocblas>`_
121+
of the `rocm-libraries GitHub <https://github.com/ROCm/rocm-libraries>`_.
117122
Verify the ROCm version on your system. On an Ubuntu distribution, use:
118123

119124
.. code-block:: shell
@@ -131,17 +136,35 @@ For example, the ROCm version might be ``4.0.0.40000-23``. This corresponds to m
131136
minor release = ``0``, patch = ``0``, and build identifier ``40000-23``.
132137
The GitHub branches at the rocBLAS site have names like ``rocm-major.minor.x``,
133138
where the major and minor releases have the same meaning as in the ROCm version.
134-
To download rocBLAS, use the following command:
139+
140+
To download rocBLAS, including all projects in the rocm-libraries repository, use the following commands.
135141

136142
.. code-block:: shell
137143
138-
git clone -b release/rocm-rel-x.y https://github.com/ROCm/rocBLAS.git
139-
cd rocBLAS
144+
git clone -b release/rocm-rel-x.y https://github.com/ROCm/rocm-libraries.git
145+
cd rocm-libraries/projects/rocblas
140146
141147
Replace ``x.y`` in the above command with the ROCm version installed on your machine.
142-
For example, if you have ROCm 6.2 installed, replace ``release/rocm-rel-x.y`` with ``release/rocm-rel-6.2``.
148+
For example, if you have ROCm 7.0 installed, replace ``release/rocm-rel-x.y`` with ``release/rocm-rel-7.0``.
149+
150+
To limit your local checkout to only the rocBLAS and Tensile projects, configure ``sparse-checkout`` before cloning.
151+
This uses the Git partial clone feature (``--filter=blob:none``) to reduce how much data is downloaded.
152+
Use the following commands for a sparse checkout:
153+
154+
.. code-block:: shell
155+
156+
git clone --no-checkout --filter=blob:none https://github.com/ROCm/rocm-libraries.git
157+
cd rocm-libraries
158+
git sparse-checkout init --cone
159+
git sparse-checkout set projects/rocblas shared/tensile
160+
git checkout develop # or use the branch you want to work with
161+
162+
.. note::
143163

164+
To build ROCm 6.4 and older, use the rocBLAS repository at `<https://github.com/ROCm/rocBLAS>`_.
165+
For more information, see the documentation associated with the release you want to build.
144166

167+
The rocBLAS source code is found in the ``projects/rocblas`` directory.
145168
The following sections list the steps to build rocBLAS using the ``install.sh`` script.
146169
You can build either:
147170

docs/install/Windows_Install_Guide.rst

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ you build rocBLAS with a different Tensile logic target. See the ``--logic`` com
8888
Download rocBLAS
8989
----------------
9090

91-
The rocBLAS source code, which is the same as the ROCm Linux version, is available from the `rocBLAS GitHub page <https://github.com/ROCm/rocBLAS>`_.
91+
The rocBLAS source code, which is the same as the ROCm Linux version, is available from the
92+
`rocBLAS folder <https://github.com/ROCm/rocm-libraries/tree/develop/projects/rocblas>`_
93+
of the `rocm-libraries GitHub <https://github.com/ROCm/rocm-libraries>`_.
9294
The ROCm HIP SDK version might appear in the default installation path,
9395
but you can run the HIP SDK compiler to display the version from the ``bin/`` folder:
9496

@@ -101,21 +103,40 @@ For example, the HIP version might be ``5.4.22880-135e1ab4``.
101103
This corresponds to major release = ``5``, minor release = ``4``, patch = ``22880``, and build identifier ``135e1ab4``.
102104
The GitHub branches at the rocBLAS site have names like ``release/rocm-rel-major.minor``,
103105
where the major and minor releases have the same meaning as in the ROCm version.
104-
To download rocBLAS, use the following command:
106+
107+
108+
To download rocBLAS, including all projects in the rocm-libraries repository, use the following commands.
105109

106110
::
107111

108-
git clone -b release/rocm-rel-x.y https://github.com/ROCm/rocBLAS.git
109-
cd rocBLAS
112+
git clone -b release/rocm-rel-x.y https://github.com/ROCm/rocm-libraries.git
113+
cd rocm-libraries/projects/rocblas
110114

111115
Replace ``x.y`` in the above command with the version of HIP SDK installed on your machine.
112-
For example, if you have HIP 5.5 installed, then use ``-b release/rocm-rel-5.5``.
116+
For example, if you have HIP 7.0 installed, use ``-b release/rocm-rel-7.0``.
113117
You can add the SDK tools to your path using an entry like this:
114118

115119
::
116120

117121
%HIP_PATH%\bin
118122

123+
To limit your local checkout to only the rocBLAS and Tensile projects, configure ``sparse-checkout`` before cloning.
124+
This uses the Git partial clone feature (``--filter=blob:none``) to reduce how much data is downloaded.
125+
Use the following commands for a sparse checkout:
126+
127+
::
128+
129+
git clone --no-checkout --filter=blob:none https://github.com/ROCm/rocm-libraries.git
130+
cd rocm-libraries
131+
git sparse-checkout init --cone
132+
git sparse-checkout set projects/rocblas shared/tensile
133+
git checkout develop # or use the branch you want to work with
134+
135+
.. note::
136+
137+
To build ROCm 6.4 and older, use the rocBLAS repository at `<https://github.com/ROCm/rocBLAS>`_.
138+
For more information, see the documentation associated with the release you want to build.
139+
119140
Building rocBLAS
120141
----------------
121142

@@ -169,6 +190,9 @@ Building the library dependencies and library
169190
Common examples of how to use ``rmake.py`` to build the library dependencies and library are
170191
shown in the table below:
171192

193+
.. note::
194+
195+
You can run ``rmake.py`` from the ``projects\rocblas`` directory.
172196

173197
.. csv-table::
174198
:header: "Command","Description"

docs/sphinx/_toc.yml.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ subtrees:
3030

3131
- caption: Examples
3232
entries:
33-
- url: https://github.com/ROCm/rocBLAS/tree/develop/clients/samples
33+
- url: https://github.com/ROCm/rocm-libraries/tree/develop/projects/rocblas/clients/samples
3434
title: rocBLAS sample code
3535

3636
- caption: API Reference

0 commit comments

Comments
 (0)