Added separate enums for exit and result codes

Author: atulkulk

tools/scripts/test_runner/lib/__init__.py

@@ -5,13 +5,15 @@
 
 from .test_config import TestConfigProcessor
 from .test_parser import ArgumentParserInterface, parse_test_output
-from .test_executor import TestExecutor
+from .test_executor import TestExecutor, ExitCode, TestResult
 
 __all__ = [
     'TestConfigProcessor',
     'ArgumentParserInterface',
     'parse_test_output',
-    'TestExecutor'
+    'TestExecutor',
+    'ExitCode',
+    'TestResult'
 ]
 
 __version__ = '1.0.0'

tools/scripts/test_runner/lib/test_executor.py

@@ -12,23 +12,33 @@
 import sys
 import time
 import datetime
+from enum import IntEnum, Enum
 from pathlib import Path
 
 # Make stdout unbuffered to prevent output ordering issues with subprocesses
 sys.stdout.reconfigure(line_buffering=True)
 
 
-class TestExecutor:
-    """
-    Executes tests and manages build/test workflows
-    """
+class ExitCode(IntEnum):
+    """Exit codes for processes"""
+    EXIT_SUCCESS = 0
+    EXIT_FAILURE = 1
+    EXIT_TIMEOUT = 124
+
 
-    # Test results
+class TestResult(str, Enum):
+    """Test result statuses"""
     RESULT_PASSED = "PASSED"
     RESULT_FAILED = "FAILED"
     RESULT_TIMEOUT = "TIMEOUT"
     RESULT_SKIPPED = "SKIPPED"
 
+
+class TestExecutor:
+    """
+    Executes tests and manages build/test workflows
+    """
+
     def __init__(self, config_processor, args):
         """
         Initialize TestExecutor
@@ -419,7 +429,7 @@ def run_test(self, test_config, suite_config):
             print(f"ERROR: Test binary not found: {test_binary_path}")
             return {
                 "name": test_name,
-                "result": self.RESULT_FAILED,
+                "result": TestResult.RESULT_FAILED.value,
                 "duration": 0,
                 "error": f"Binary not found: {test_binary_path}"
             }
@@ -556,12 +566,12 @@ def run_test(self, test_config, suite_config):
             duration = time.time() - start_time
 
             # Determine result
-            if result.returncode == 0:
-                test_result = self.RESULT_PASSED
-            elif result.returncode == self.EXIT_TIMEOUT:
-                test_result = self.RESULT_TIMEOUT
+            if result.returncode == ExitCode.EXIT_SUCCESS:
+                test_result = TestResult.RESULT_PASSED.value
+            elif result.returncode == ExitCode.EXIT_TIMEOUT:
+                test_result = TestResult.RESULT_TIMEOUT.value
             else:
-                test_result = self.RESULT_FAILED
+                test_result = TestResult.RESULT_FAILED.value
 
             if self.args.verbose:
                 print(f"\n  Result: {test_result} ({duration:.3f} seconds)")
@@ -576,10 +586,10 @@ def run_test(self, test_config, suite_config):
         except subprocess.TimeoutExpired:
             duration = time.time() - start_time
             if self.args.verbose:
-                print(f"\n  Result: {self.RESULT_TIMEOUT} after {timeout} seconds")
+                print(f"\n  Result: {TestResult.RESULT_TIMEOUT.value} after {timeout} seconds")
             return {
                 "name": test_name,
-                "result": self.RESULT_TIMEOUT,
+                "result": TestResult.RESULT_TIMEOUT.value,
                 "duration": duration,
                 "error": f"Test timed out after {timeout} seconds"
             }
@@ -588,7 +598,7 @@ def run_test(self, test_config, suite_config):
             print(f"\n  ERROR: {e}")
             return {
                 "name": test_name,
-                "result": self.RESULT_FAILED,
+                "result": TestResult.RESULT_FAILED.value,
                 "duration": duration,
                 "error": str(e)
             }
@@ -636,9 +646,9 @@ def run_test_suite(self, suite_config):
     def print_summary(self):
         """Print test execution summary"""
         total_tests = len(self.test_results)
-        passed = self.test_results.count(self.RESULT_PASSED)
-        failed = self.test_results.count(self.RESULT_FAILED)
-        timeout = self.test_results.count(self.RESULT_TIMEOUT)
+        passed = self.test_results.count(TestResult.RESULT_PASSED.value)
+        failed = self.test_results.count(TestResult.RESULT_FAILED.value)
+        timeout = self.test_results.count(TestResult.RESULT_TIMEOUT.value)
 
         # Get unique test suites that were run
         unique_suites = sorted(set(self.test_suites)) if self.test_suites else []

tools/scripts/test_runner/test_runner.py

@@ -93,8 +93,9 @@ def main():
 
         # Return based on results
         if executor.test_results:
-            failed = executor.test_results.count(executor.RESULT_FAILED)
-            timeout = executor.test_results.count(executor.RESULT_TIMEOUT)
+            from lib.test_executor import TestResult
+            failed = executor.test_results.count(TestResult.RESULT_FAILED.value)
+            timeout = executor.test_results.count(TestResult.RESULT_TIMEOUT.value)
             if failed > 0 or timeout > 0:
                 if args.verbose:
                     print(f"Exiting: Tests failed (failed={failed}, timeout={timeout})")