Skip to content

tools support for multiple models run #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coketaste wants to merge 2 commits into
base: main
Choose a base branch
from
+40 −6
Open

tools support for multiple models run #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebb7501
This ensures that when running multiple models sequentially, each mod…
coketaste Jul 10, 2025
9d74c04
Merge branch 'main' into coketaste/tools
gargrahul Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/madengine/scripts/common/post_scripts/gpu_info_post.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,15 @@ set -e
set -x

tool=$1
model_name=$2

# Use model name if provided, otherwise fallback to tool name
if [ -n "$model_name" ]; then
OUTPUT=${tool}_${model_name}_output.csv
else
OUTPUT=${tool}_output.csv
fi

OUTPUT=${tool}_output.csv
SAVESPACE=/myworkspace/

cd $SAVESPACE
Expand Down
24 changes: 22 additions & 2 deletions src/madengine/scripts/common/post_scripts/trace.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,15 @@ set -e
set -x

tool=$1
model_name=$2

# Use model name if provided, otherwise fallback to tool name
if [ -n "$model_name" ]; then
OUTPUT=${tool}_${model_name}_output
else
OUTPUT=${tool}_output
fi

OUTPUT=${tool}_output
SAVESPACE=/myworkspace/

mkdir "$OUTPUT"
Expand All @@ -18,7 +25,20 @@ case "$tool" in

rpd)
python3 ./rocmProfileData/tools/rpd2tracing.py trace.rpd trace.json
mv trace.rpd trace.json "$OUTPUT"

# Rename trace files with model name if provided
if [ -n "$model_name" ]; then
if [ -f "trace.rpd" ]; then
mv trace.rpd "trace_${model_name}.rpd"
fi
if [ -f "trace.json" ]; then
mv trace.json "trace_${model_name}.json"
fi
mv "trace_${model_name}.rpd" "trace_${model_name}.json" "$OUTPUT" 2>/dev/null || true
else
mv trace.rpd trace.json "$OUTPUT" 2>/dev/null || true
fi

cp -vLR --preserve=all "$OUTPUT" "$SAVESPACE"
;;

Expand Down
13 changes: 10 additions & 3 deletions src/madengine/tools/run_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ def get_mount_arg(self, mount_datapaths: typing.List) -> str:

return mount_args

def run_pre_post_script(self, model_docker, model_dir, pre_post):
def run_pre_post_script(self, model_docker, model_dir, pre_post, model_name=None):
for script in pre_post:
script_path = script["path"].strip()
model_docker.sh("cp -vLR --preserve=all " + script_path + " " + model_dir, timeout=600)
Expand All @@ -527,6 +527,13 @@ def run_pre_post_script(self, model_docker, model_dir, pre_post):
if "args" in script:
script_args = script["args"]
script_args.strip()

# Add model name as an additional argument if provided
if model_name:
# Clean model name for safe file naming (replace / with _)
safe_model_name = model_name.replace("/", "_")
script_args += f" {safe_model_name}"

model_docker.sh("cd " + model_dir + " && bash " + script_name + " " + script_args , timeout=600)

def run_model_impl(
Expand Down Expand Up @@ -779,7 +786,7 @@ def run_model_impl(
self.gather_system_env_details(pre_encapsulate_post_scripts, info['name'])
# run pre_scripts
if pre_encapsulate_post_scripts["pre_scripts"]:
self.run_pre_post_script(model_docker, model_dir, pre_encapsulate_post_scripts["pre_scripts"])
self.run_pre_post_script(model_docker, model_dir, pre_encapsulate_post_scripts["pre_scripts"], info['name'])

scripts_arg = info['scripts']
dir_path = None
Expand Down Expand Up @@ -868,7 +875,7 @@ def run_model_impl(

# run post_scripts
if pre_encapsulate_post_scripts["post_scripts"]:
self.run_pre_post_script(model_docker, model_dir, pre_encapsulate_post_scripts["post_scripts"])
self.run_pre_post_script(model_docker, model_dir, pre_encapsulate_post_scripts["post_scripts"], info['name'])

# remove model directory
if not self.args.keep_alive and not self.args.keep_model_dir:
Expand Down