Skip to content

[Feature]: Re-hipify changed source files #81

@stepeos

Description

@stepeos

Suggestion Description

Hi!

from my understanding, the current setup only copies cuda project source files to hip output directory with

hipify_python.py:1130

shutil.copytree(project_directory, output_directory)

and then skips hipifying all files that are already hipifyed.

Now I assume this was intented to be used as one-time submit command in cmake. The problem I see with this is what happens if I make changes to my cuda source files?
The current result is that the files are skipped as they are seen as already hipifyed:
in hipify_python.py::preprocessor, the hipified source file is read and compared against (you guessed it) the hipified source file. So you re-hipify the source file and detect changes but from my understanding the hip source file will not ever change since changes to cuda source files are not detected.

One can circumvent this by always copying the cuda source tree by commenting out the if-condition.

So my question is why not make it default behavior or an override flag or more checks for such source file changes?

Operating System

No response

GPU

No response

ROCm Component

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions