chore: auto-update QPK_PIN and pin manifests#214
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ee4002034
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@c3b50ff1086b4e2f059d61a270c5e6cb85e65808 | ||
| us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@769ed979b476ad0392372eb760af9a77b3dbaeff | ||
| hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@54011c321427b1bfc343a421287c991a949961ba | ||
| cn-equity-strategies @ git+https://github.com/QuantStrategyLab/CnEquityStrategies.git@e969359a89e13a1aab4b8e4469d2362c6eadc1c9 | ||
| crypto-strategies @ git+https://github.com/QuantStrategyLab/CryptoStrategies.git@b05d40cd4fbe07207afe3806c814e8b50077dd0a |
There was a problem hiding this comment.
Keep strategy pins aligned with the new QPK SHA
The new bundle pins QPK to c3b50ff..., but the strategy commits selected here still declare a direct dependency on quant-platform-kit @ ...69a025... in their own pyproject.toml files (for example, UsEquityStrategies@769ed979; the HK/CN/Crypto refs have the same old QPK pin). Any downstream install that uses qsl-pins.txt/constraints.txt with dependencies enabled will make pip resolve two different direct URL requirements for quant-platform-kit, causing the ResolutionImpossible drift this manifest is meant to prevent; please only advance these strategy SHAs after their internal QPK pins are updated to c3b50ff..., or keep the previous strategy refs.
Useful? React with 👍 / 👎.
| quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@c3b50ff1086b4e2f059d61a270c5e6cb85e65808 | ||
| us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@769ed979b476ad0392372eb760af9a77b3dbaeff | ||
| hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@54011c321427b1bfc343a421287c991a949961ba | ||
| cn-equity-strategies @ git+https://github.com/QuantStrategyLab/CnEquityStrategies.git@e969359a89e13a1aab4b8e4469d2362c6eadc1c9 |
There was a problem hiding this comment.
Regenerate the Cn strategy lockfile before pinning it
The newly selected Cn strategy commit has a stale uv.lock: its metadata requests QPK at 69a025..., but the locked quant-platform-kit package source resolves to ...?rev=69a025...#53b2ca... in that commit's lockfile. uv documents that sync installs from the lockfile and that --locked errors rather than updating stale locks, so Cn CI/deploys using this pinned SHA will either keep exercising the old QPK tree or fail once they require the lock to match; please pin a Cn commit with uv.lock regenerated consistently.
Useful? React with 👍 / 👎.
4ee4002 to
5720477
Compare
🤖 Codex PR Review✅ Merge allowed: No issues found Review by Codex PR Review bot • PR |
|
Reopening to run the newly merged trusted-base Codex review gate against this existing same-repository PR. |
|
Retesting the central Codex review gate after its deployed-model fix. |
5720477 to
74e6530
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74e6530468
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@549a06508c343df81a9ab133d9df9fe0be299738 | ||
| hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@9cab96cd1d5f0d4d93eb23fee1d3eddf68bb8dcd | ||
| cn-equity-strategies @ git+https://github.com/QuantStrategyLab/CnEquityStrategies.git@e969359a89e13a1aab4b8e4469d2362c6eadc1c9 | ||
| crypto-strategies @ git+https://github.com/QuantStrategyLab/CryptoStrategies.git@b05d40cd4fbe07207afe3806c814e8b50077dd0a |
There was a problem hiding this comment.
Align strategy pins with the QPK SHA
Fresh evidence for the stale earlier comment: the current refs selected here (Us@549a..., Hk@9cab..., Cn@e969..., and Crypto@b05d...) still declare direct pyproject.toml dependencies on quant-platform-kit@69a025..., while this manifest constrains QPK to 7fb3e1c.... Any downstream pip/uv install that consumes qsl-pins.txt or constraints.txt with dependencies enabled must satisfy two different direct URL requirements for quant-platform-kit, so it will fail resolution instead of exercising the new QPK build; please only advance these strategy refs once their internal QPK pins match the new SHA, or keep compatible strategy refs.
Useful? React with 👍 / 👎.
74e6530 to
beebcfb
Compare
|
Closing this auto pin-roll PR for now to avoid reopening a downstream pin rollout immediately after the sell-funded buy incident fixes. Current downstream fix repos are intentionally kept on QPK@2381aa4577e9 until we schedule a coordinated pin wave. |
Automated update of QPK_PIN and QSL Git SHA pin manifests.
Compatibility checks passed ✅ — all downstream-critical QPK modules verified importable.
Updated SHAs:
acdf954ac9e7bbfae734bdf17249765172459458🤖 Generated with Claude Code