Upgrade cache actions to Node 24

Author: Pigbibi

.github/workflows/monthly_advisory_review.yml

@@ -50,8 +50,6 @@ on:
   schedule:
     - cron: "20 13 1 * *"
 
-env:
-  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
 
 jobs:
   build-monthly-review:
@@ -78,7 +76,7 @@ jobs:
         working-directory: advisor
         run: python -m pip install -e .
       - name: Restore market data cache
-        uses: actions/cache/restore@v4
+        uses: actions/cache/restore@v5
         continue-on-error: true
         with:
           path: advisor/.cache/market-data
@@ -130,7 +128,7 @@ jobs:
           python scripts/build_advisory_artifacts.py "${ARGS[@]}"
       - name: Save market data cache
         if: ${{ success() }}
-        uses: actions/cache/save@v4
+        uses: actions/cache/save@v5
         continue-on-error: true
         with:
           path: advisor/.cache/market-data

.github/workflows/publish_advisory_site.yml

@@ -55,8 +55,6 @@ permissions:
   pages: write
   id-token: write
 
-env:
-  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
 
 jobs:
   build-site:
@@ -86,7 +84,7 @@ jobs:
         working-directory: advisor
         run: python -m pip install -e .
       - name: Restore market data cache
-        uses: actions/cache/restore@v4
+        uses: actions/cache/restore@v5
         continue-on-error: true
         with:
           path: advisor/.cache/market-data
@@ -139,7 +137,7 @@ jobs:
           python scripts/build_advisory_artifacts.py "${ARGS[@]}"
       - name: Save market data cache
         if: ${{ success() }}
-        uses: actions/cache/save@v4
+        uses: actions/cache/save@v5
         continue-on-error: true
         with:
           path: advisor/.cache/market-data

.github/workflows/weekly_advisory_review.yml

@@ -45,8 +45,6 @@ on:
   schedule:
     - cron: "30 12 * * 6"
 
-env:
-  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
 
 jobs:
   build-review:
@@ -73,7 +71,7 @@ jobs:
         working-directory: advisor
         run: python -m pip install -e .
       - name: Restore market data cache
-        uses: actions/cache/restore@v4
+        uses: actions/cache/restore@v5
         continue-on-error: true
         with:
           path: advisor/.cache/market-data
@@ -120,7 +118,7 @@ jobs:
           python scripts/build_advisory_artifacts.py "${ARGS[@]}"
       - name: Save market data cache
         if: ${{ success() }}
-        uses: actions/cache/save@v4
+        uses: actions/cache/save@v5
         continue-on-error: true
         with:
           path: advisor/.cache/market-data

tests/test_workflow_defaults.py

@@ -20,8 +20,8 @@ def test_public_workflows_default_to_live_event_inputs() -> None:
         assert "scripts/build_market_confirmation.py" not in text
         assert "market_data_proxy_urls" in text
         assert "MARKET_DATA_PROXY_POOL_URL" in text
-        assert "actions/cache/restore@v4" in text
-        assert "actions/cache/save@v4" in text
+        assert "actions/cache/restore@v5" in text
+        assert "actions/cache/save@v5" in text
         assert "--market-cache-dir .cache/market-data" in text
         assert "--recommendation-review" in text