Skip to content

chore(governance): harden review gate and qsl metadata#217

Merged
Pigbibi merged 1 commit into
mainfrom
codex/p0-p5-runtime-governance-20260710
Jul 10, 2026
Merged

chore(governance): harden review gate and qsl metadata#217
Pigbibi merged 1 commit into
mainfrom
codex/p0-p5-runtime-governance-20260710

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Part of the QuantStrategyLab P0-P5 hardening and convergence wave.

Highlights:

  • tighten governance / QSL metadata / runtime reporting where applicable
  • keep changes minimal and repository-scoped

Local validation was run before push in the Codex execution session.

@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Pigbibi Pigbibi force-pushed the codex/p0-p5-runtime-governance-20260710 branch from 77f69f0 to e5b3bbd Compare July 10, 2026 02:03
@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77f69f066e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


jobs:
review:
uses: QuantStrategyLab/AIAuditBridge/.github/workflows/codex_pr_review.yml@main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Stop enabling a reusable review workflow that cannot checkout

When this new PR workflow calls QuantStrategyLab/AIAuditBridge/.github/workflows/codex_pr_review.yml@main, the called workflow runs under the caller PR context; its Checkout bridge review scripts step currently resolves the bridge checkout ref to github.event.pull_request.base.sha, which is a FirstradePlatform commit SHA, not an AIAuditBridge ref. That makes this job fail before it can review any PR, so enabling it here adds a consistently failing PR check whenever the workflow runs.

Useful? React with 👍 / 👎.

Comment thread .github/codex_auto_merge_policy.json Outdated
"max_diff_lines": 2400,
"block_on_review_failure": false
"auto_converge_after": 0,
"block_on_review_failure": true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wire block_on_review_failure into the gate

Setting this to true does not actually change the existing Codex Review Gate behavior: scripts/gate_codex_app_review.py reads this policy file for static limits but never consults pr_review.block_on_review_failure, and its timeout path still unconditionally returns success. In any PR where the existing gate is the enforced check and the Codex app fails or times out, merges continue to pass despite the policy now saying review failures should block.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi force-pushed the codex/p0-p5-runtime-governance-20260710 branch from e5b3bbd to 660322c Compare July 10, 2026 02:11
@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions

Copy link
Copy Markdown

🤖 Codex PR Review

⚠️ Human review required: The Codex review could not be completed.

Codex service request failed: 401 {"status": "error", "error": "OIDC repository is not allowed"}

Please ensure a human reviewer checks this PR before merging.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi force-pushed the codex/p0-p5-runtime-governance-20260710 branch from 660322c to 0d42873 Compare July 10, 2026 02:29
@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Pigbibi Pigbibi merged commit 7964bc3 into main Jul 10, 2026
2 of 3 checks passed
@Pigbibi Pigbibi deleted the codex/p0-p5-runtime-governance-20260710 branch July 10, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant