Skip to content

feat(risk): stamp consecutive_losses before strategy evaluate#216

Merged
Pigbibi merged 1 commit into
mainfrom
feat/wire-consecutive-losses-metadata
Jul 9, 2026
Merged

feat(risk): stamp consecutive_losses before strategy evaluate#216
Pigbibi merged 1 commit into
mainfrom
feat/wire-consecutive-losses-metadata

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Stamp consecutive_losses onto portfolio_snapshot before strategy evaluate via QPK stamp_consecutive_losses_on_snapshot
  • Bump QPK pin to 69a0256 (QPK #211)
  • Entrypoint risk gates can trip the >5 consecutive-loss circuit breaker once live equity history exists

Test plan

  • Local stamp unit test
  • CI green

Made with Cursor

Reuse QPK stamp helper so entrypoint circuit breakers see trailing
loss streak from live equity history.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 9, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Pigbibi Pigbibi merged commit 2284ad8 into main Jul 9, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d30222257

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread uv.lock
name = "quant-platform-kit"
version = "0.10.0"
source = { git = "https://github.com/QuantStrategyLab/QuantPlatformKit.git?rev=53b2ca73a5a50257b5d1a3c769b75c40924e4ba6#53b2ca73a5a50257b5d1a3c769b75c40924e4ba6" }
source = { git = "https://github.com/QuantStrategyLab/QuantPlatformKit.git?rev=69a0256934d081b5ef309a885384b9eb9f62cf90#53b2ca73a5a50257b5d1a3c769b75c40924e4ba6" }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve the locked QPK revision to the new commit

In frozen uv environments this lock entry still resolves quant-platform-kit to the old commit after the # fragment; I checked uv export --frozen --no-dev --no-hashes and it emits quant-platform-kit @ ...@53b2ca73..., not 69a02569.... CI/Docker/env sync all use frozen uv installs, so the new runtime import of stamp_consecutive_losses_on_snapshot will run against the old QPK revision and fail before the strategy can evaluate.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi deleted the feat/wire-consecutive-losses-metadata branch July 9, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant