DOC: Update docstrings in lqnash.jl to follow style guide#345
Merged
Conversation
Co-authored-by: sudayuga <231150606+sudayuga@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update docstrings in lqnash.jl
DOC: Update docstrings in lqnash.jl to follow style guide
Oct 21, 2025
oyamad
requested changes
Oct 21, 2025
| =# | ||
|
|
||
| @doc doc""" | ||
| nnash(a, b1, b2, r1, r2, q1, q2, s1, s2, w1, w2, m1, m2; beta=1.0, tol=1e-8, max_iter=1000) |
Member
There was a problem hiding this comment.
@copilot
Capitalize the variable names a, ..., m2, consistent with those in the descriptions.
Contributor
Author
There was a problem hiding this comment.
Capitalized all variable names in the function signature to match the argument descriptions in commit 88b3dd6.
Co-authored-by: oyamad <7353083+oyamad@users.noreply.github.com>
Contributor
Author
Capitalized the variables in the equations (R_i, W_i, Q_i, S_i, M_i, B_1, B_2) and added the missing β^{t-1} discount term in commit 88b3dd6. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
oyamad
approved these changes
Oct 21, 2025
Closed
sudayuga
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the docstring for the
nnashfunction insrc/lqnash.jlto follow the conventions specified in.github/copilot-instructions.md.Changes Made
Added function signature - The docstring now starts with a four-space indented function signature showing the function name and all parameters with their default values:
Updated section headers - Changed from
#####to single#for "Arguments" and "Returns" sections to match the standard style used throughout the codebaseImproved consistency - All parameter and return value descriptions now end with periods for consistency
Fixed typos - Corrected spelling errors:
Capitalized variable names - All variable names in the function signature and mathematical equations now use uppercase to match the argument descriptions:
A,B1,B2,R1,R2,Q1,Q2,S1,S2,W1,W2,M1,M2R_i,W_i,Q_i,S_i,M_i,B_1,B_2Added missing discount term - Added the missing
\beta^{t-1}discount factor in the minimization equationPreserved mathematical notation - Maintained the
@doc doc"""syntax for proper LaTeX rendering in the documentationThe updated docstring provides clearer documentation and follows the established conventions used in other files like
compute_fp.jlandarma.jl.Verification
Original prompt
<issue_description>Follow the instruction in .github/copilot-instructions.md.
Scope: Only edit docstrings in lqnash.jl</issue_description>
Comments on the Issue (you are @copilot in this section)
Fixes #344
Original prompt
Fixes #344
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.