How can I clear a certain buff from player?

[ALEX2014-git]

I want to clear a certain buff from player inside my command method.
Currently I have this code that successfully applies debuff for default duration of a minute.

    void MyCommandEvenHandler(CommandArgs args)
    {
          args.Player.SetBuff(BuffID.Webbed); 
    }

This works, when executed targeted players gets webbed for 1 minute.
But then I want to be able to prematurely end it.
I tried this commands

args.Player.SetBuff(BuffID.Webbed, 1);
args.Player.SetBuff(BuffID.Webbed, 0);
args.TPlayer.ClearBuff(BuffID.Webbed);
NetMessage.SendData(MessageID.PlayerBuffs, -1, -1, null, args.TPlayer.whoAmI);
 args.Player.SendData(PacketTypes.PlayerBuff); 

None can do the trick. Buff will never get cleared or sets up to 1 tick.
How can I achieve my desired action?
I'm new to Terraria Modding, never used tModLoader, but I have experience of Unity modding and C# native hooks.

(Also, on a side note, when I tried to use

args.TPlayer.AddBuff(BuffID.Webbed, 3600, false);

It didn't do anything, I assume this has to do with networking stuff, but I'm curios how can I use Terraria methods via TShock plugin and can I even?)

[ACaiCat]

Plugin can only apply buffs, not remove them.

[ALEX2014-git]

Plugin can only apply buffs, not remove them.

Why can my plugin hook to the internal methods and modify their state but not remove the buff if Terraria namespace declares ClearBuff() method that I can call through either args.TPlayer or Main.player[i]?

[ACaiCat]

Hmmm, maybe ClearBuff() only works on the client side.

[zyrafaq]

It works when SSC is enabled. I have seen it in action. Though you need to tell the client the updated buffs

[zyrafaq]

You can't end the buff. (you could if ssc was enabled using a non documented packet). Your best option here is to apply the buff each few ticks with a duration of a second and then stop applying it.

[sgkoishi]

Those are all about directions. You can do these as a player (from the client to the server), but not the opposite way from the server to the client (while keeping all the other buffs and time).

[ACaiCat]

Minecraft's client-server model (even in singleplayer) gives the server full control, unlike Terraria. But I think Terraria's multiplayer has better performance (?)

[ALEX2014-git]

Hook to OnUpdate hook and set the buff normally (using addbuff) if your custom condition like the player being in a list being positive

I tried to do it like so, but my debuff aren't being applied.

    private void Player_Update(On.Terraria.Player.orig_Update orig, Player self, int i)
    {
        orig(self, i);
        if (self.GetCustomData().isAFK)
        {
            if (self.GetCustomData().afkDebuffCooldown <= 0)
            {
                self.AddBuff(BuffID.Webbed, 60, false);
                self.GetCustomData().afkDebuffCooldown = 60;
                TShock.Log.ConsoleInfo($"Trying to apply debuff");
            }
            self.GetCustomData().afkDebuffCooldown--;
            TShock.Log.ConsoleInfo($"Current afk debuff cd: {self.GetCustomData().afkDebuffCooldown}");
        }
    }

[sors89]

Hook to OnUpdate hook and set the buff normally (using addbuff) if your custom condition like the player being in a list being positive

I tried to do it like so, but my debuff aren't being applied.

    private void Player_Update(On.Terraria.Player.orig_Update orig, Player self, int i)
    {
        orig(self, i);
        if (self.GetCustomData().isAFK)
        {
            if (self.GetCustomData().afkDebuffCooldown <= 0)
            {
                self.AddBuff(BuffID.Webbed, 60, false);
                self.GetCustomData().afkDebuffCooldown = 60;
                TShock.Log.ConsoleInfo($"Trying to apply debuff");
            }
            self.GetCustomData().afkDebuffCooldown--;
            TShock.Log.ConsoleInfo($"Current afk debuff cd: {self.GetCustomData().afkDebuffCooldown}");
        }
    }

iirc, you also have to send a packet to update the client or alternatively, use:

TShock.Players[self.whoAmI].SetBuff(BuffID.Webbed, 60);

[zyrafaq]

Hook to OnUpdate hook and set the buff normally (using addbuff) if your custom condition like the player being in a list being positive

I tried to do it like so, but my debuff aren't being applied.

    private void Player_Update(On.Terraria.Player.orig_Update orig, Player self, int i)
    {
        orig(self, i);
        if (self.GetCustomData().isAFK)
        {
            if (self.GetCustomData().afkDebuffCooldown <= 0)
            {
                self.AddBuff(BuffID.Webbed, 60, false);
                self.GetCustomData().afkDebuffCooldown = 60;
                TShock.Log.ConsoleInfo($"Trying to apply debuff");
            }
            self.GetCustomData().afkDebuffCooldown--;
            TShock.Log.ConsoleInfo($"Current afk debuff cd: {self.GetCustomData().afkDebuffCooldown}");
        }
    }

did it show the log messages?

[ALEX2014-git]

iirc, you also have to send a packet to update the client or alternatively, use:

TShock.Players[self.whoAmI].SetBuff(BuffID.Webbed, 60);

This worked, although I'm curios how do I send the package in order to update client if I'm already using internal method call to the SetBuff method?

[sors89]

iirc, you also have to send a packet to update the client or alternatively, use:

TShock.Players[self.whoAmI].SetBuff(BuffID.Webbed, 60);

This worked, although I'm curios how do I send the package in order to update client if I'm already using internal method call to the SetBuff method?

My mistake, the packet i mentioned isn't actually an update packet, rather it requests the target client to self-buff through the AddBuff method. The AddBuff method isn't networked so that's the reason why it doesn't work when you call it directly from the server. TShock's built-in SetBuff method sends packet 55 which does exactly what i explained above.

[sgkoishi]

There is a ClearBuff but it was the vanilla client side logic. Of course you can call it, the only problem is the server can't tell the client about this, no such functionality exists.
SSC stands for Server Side Character, and it is required if you want to change literally anything of the player.

[sgkoishi]

The UpdatePlayerBuff do not sync the time, but just types of the buff. AddBuff do have time and perhaps you can try and see if negative numbers works

[zyrafaq]

Use:

TSPlayer.All.SendData(PacketTypes.PlayerBuff, number: player.Index);

[zyrafaq]

Has your issue been resolved? @ALEX2014-git
If yes please close this discussion with an answer

[ALEX2014-git]

The final solution that I used is a proposed idea to instead apply effect constantly and rely on it's timer to end instead of clearing it manually.
Not the solution I was looking after, and with the access to the internal methods I feel like better solution can be found, but I'm not familiar with game structure yet, so I will stop there for now.

Thanks everyone for discussion!
Here's my final code if anyone would ever stumbles upon this and will need a reference.

public class Mod
{
///other methods here, such as mod ctor and initialization, afk flag is set and revoked via chat command

    public override void Initialize()
    {
        On.Terraria.Player.Update += Player_Update;
    }

    private void Player_Update(On.Terraria.Player.orig_Update orig, Player self, int i)
    {
        orig(self, i);
        if (self.GetCustomData().isAFK)
        {
            if (self.GetCustomData().afkDebuffCooldown <= 0)
            {
                TShock.Players[self.whoAmI].SetBuff(BuffID.Webbed, 30);
                self.GetCustomData().afkDebuffCooldown = 25;
            }
            self.GetCustomData().afkDebuffCooldown--;
        }
    }
}

public static class PlayerCWT
{
    static ConditionalWeakTable<Player, Data> table = new ConditionalWeakTable<Player, Data>();

    public static Data GetCustomData(this Player self) => table.GetOrCreateValue(self);

    public class Data
    {
        public bool isAFK;
        public int afkDebuffCooldown;
    }
}

[zyrafaq]

Please select an answer for this so someone finding this knows which message helped you the most