[Bug] Syncing storage with the ledger at bootup failed — Transaction 'X' was aborted in block 'A'

[vicsn]

🐛 Bug Report

This happened after restarting a node which was experiencing syncing issues on v4.6.4

The error message is a little opaque but I am pretty certain it happens when calling LedgerService::get_block at the beginning of snarkos_node_bft::Sync::sync_storage_with_ledger_at_bootup . When fetching the block one of its committed transaction is marked as aborted in storage.

I will make a PR to add better error messages for this. Most likely there is a bug when advancing the ledger, because a transaction should either be part of a block or in the set of aborted transaction, but never both.