Compiling on debian 12

[datendelphin]

Issue

Compiling on debian 12 I get the following error:

In file included from /usr/include/boost/asio.hpp:23,
                 from /srv/osrm/osrm-backend/include/server/http/reply.hpp:6,
                 from /srv/osrm/osrm-backend/include/server/connection.hpp:5,
                 from /srv/osrm/osrm-backend/src/server/connection.cpp:1:
/usr/include/boost/asio/awaitable.hpp: In constructor ‘boost::asio::awaitable<T, Executor>::awaitable(boost::asio::awaitable<T, Executor>&&)’:
/usr/include/boost/asio/awaitable.hpp:68:19: error: ‘exchange’ is not a member of ‘std’; did you mean ‘std::__atomic_impl::exchange’?
   68 |     : frame_(std::exchange(other.frame_, nullptr))
      |                   ^~~~~~~~
In file included from /usr/include/c++/12/bits/shared_ptr_atomic.h:33,
                 from /usr/include/c++/12/memory:78,
                 from /usr/include/boost/asio/associated_allocator.hpp:19,
                 from /usr/include/boost/asio.hpp:20:
/usr/include/c++/12/bits/atomic_base.h:976:7: note: ‘std::__atomic_impl::exchange’ declared here
  976 |       exchange(_Tp* __ptr, _Val<_Tp> __desired, memory_order __m) noexcept
      |       ^~~~~~~~

Seems to be a problem of boost asio on debian.

Workaround:

adding
#include <utility>
before the #include <boost/asio.hpp>

Specifications

• Debian 12
• gcc 12.2

[DennisOSRM]

What revision are you using? Latest master branch?

[datendelphin]

Tag v6.0.0-rc.2 which seems to be the current master

[DennisOSRM]

Quick update: The issue seems to be limited to boost 1.74. When compiling with boost 1.81 from Debian bookworm repos, it succeeds (after disabling -werror.

[datendelphin]

Ah true, there are two versions on Debian bookworm, and the 1.74 seems to be the default, as I didn't specify a version

[datendelphin]

I just tried 1.81 and with that I get two errors. Or one without -Werror.
Adding #include <vector> to suffix_table.hpp resolves both

[DennisOSRM]

Hmm.. isn't vector already included in suffix_table.hpp? Or am I looking in the wrong place?

osrm-backend/include/extractor/suffix_table.hpp

Line 7 in f5e9241

#include <vector>

[datendelphin]

You are right. For some reason I was back to v5.27.1 when I compiled it again yesterday. Sorry.
With v6.0.0-rc.1 I was glad for your hint with the -Werror. Now it's running :)

So to summarize, use boost 1.81 on bookworm and don't turn warnings into errors.

[DennisOSRM]

Cool, glad to know it works. Thanks for the update.

[datendelphin]

Another data point: clang-16 with boost 1.81 also works fine, no disabling of -werror needed. But there is a newer clang available on debian, and that does not work with current v6 sources.