Skip to content

Update dashboard.md fix nvidia.com/gpucores comment#1712

Merged
hami-robot[bot] merged 1 commit intoProject-HAMi:masterfrom
Nov11:Nov11-patch-1
Mar 30, 2026
Merged

Update dashboard.md fix nvidia.com/gpucores comment#1712
hami-robot[bot] merged 1 commit intoProject-HAMi:masterfrom
Nov11:Nov11-patch-1

Conversation

@Nov11
Copy link
Copy Markdown
Contributor

@Nov11 Nov11 commented Mar 26, 2026

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hami-robot
Copy link
Copy Markdown
Contributor

hami-robot bot commented Mar 26, 2026

Welcome @Nov11! It looks like this is your first PR to Project-HAMi/HAMi 🎉

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor documentation error by updating a comment in the dashboard.md file. The change ensures that the explanation for the nvidia.com/gpucores resource accurately reflects the intended percentage, improving clarity and correctness for users referencing the dashboard documentation.

Highlights

  • Documentation Correction: Corrected a misleading comment in dashboard.md that incorrectly stated the percentage for nvidia.com/gpucores from 30% to 10%.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hami-robot hami-robot bot added the size/XS label Mar 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the docs/dashboard.md file to correct the description of nvidia.com/gpucores, changing the percentage from 30% to 10%. The review suggests an improvement to the documentation for consistency and readability, recommending the use of half-width parentheses and a space after the comma in the (Optional, Integer) description.

Signed-off-by: Nov11 <529079634@qq.com>
Copy link
Copy Markdown
Member

@archlitchi archlitchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hami-robot
Copy link
Copy Markdown
Contributor

hami-robot bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, Nov11

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot bot added the approved label Mar 30, 2026
@hami-robot hami-robot bot merged commit deff5c0 into Project-HAMi:master Mar 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants