Do not install Checkout on PHP 7.1

[Quetzacoalt91]

Following the discussion #1357, one first fix has been brought to the project for shops running PHP 7.1.

This removes one fatal error when the autoloader was called, good 👍, however...

The installation of Checkout on shops running PHP 7.1 is still allowed and must be fixed to avoid issues while accessing the backoffice:

Actions needed:

• Refuse to install / uninstall the module if the current PHP version is not compatible with the module (return false before running any action on the shop)
• Because the module is pre-installed with PrestaShop, the installation of the shop depends on the accomplishment of each module installation. In this context, I recommend retuning true even if the module is not installed to allow the installation of PrestaShop to complete.
• Move the inclusion of the autoloader after having checked PHP is compliant with your dependancies. Otherwise any load of class may trigger this kind of error.

    public function __construct()
    {
        $this->name = 'ps_checkout';
        // Rest of definition of the module properties ...

        // If PHP is not compliant, we will not load composer and the autoloader
        if (!$this->isPhpVersionCompliant()) {
            return;
        }

        require_once __DIR__ . '/vendor/autoload.php';

        // You may now use the classes of the project
    }
    public function install()
    {
        if (!$this->isPhpVersionCompliant()) {
            $this->_errors[] = $this->l('This module requires at least PHP 7.2.5 to work properly. Please upgrade your server configuration.');

            // We return true during the installation of PrestaShop to not stop the whole process,
            // Otherwise we warn properly the installation failed.
            return defined('PS_INSTALLATION_IN_PROGRESS');
        }

       // Full installation

        return true;
    }

    public function uninstall()
    {
        // If PHP is not compliant, we do the basic steps to uninstall the module
        if (!$this->isPhpVersionCompliant()) {
            return parent::uninstall();
        }

        // Full uninstallation
    }

    private function isPhpVersionCompliant()
    {
        return 70205 <= PHP_VERSION_ID;
    }

Thanks

[matks]

Hello we want to make ps_checkout compatible with PHP7.1 but when we tried to add it into v5.0.3 we saw it actually needed a lot more work because PHP7.2 brought backward incompatible changes compared to PHP 7.1 😅

I hope we can add PHP7.1 compatibility inside v5.0.4, but this is quite dependent on how our composer dependencies depend themselves on PHP7.1 / PHP 7.2 😬

[Quetzacoalt91]

It can be tricky to increase the compatibility, indeed. The changes I suggest allow you to keep the current compatibility without breaking shops that would start using the module, so you can stay focused on the features.

[matks]

@Quetzacoalt91 What about $this->php_versions_compliancy in module class?

[Quetzacoalt91]

This property does not exist. PrestaShop lacks a native check of PHP versions regarding modules, this must be done manually until we get Composer.

[matks]

I saw it there https://github.com/PrestaShopCorp/builtforjsexample/blob/5c65b8b65aea84a03814581225fbf08da23c5047/builtforjsexample.php#L61

I remember Dimitri talking about it for marketplace. I will dig in to find if it is usable.

[matks]

Move the inclusion of the autoloader after having checked PHP is compliant with your dependancies. Otherwise any load of class may trigger this kind of error.

Isn't the inclusion of autoloader done automatically by the core? Can you provide an example of one module doing it?

[Quetzacoalt91]

It is if the module is installed / active. But Checkout does it as well:

ps_checkout/ps9/ps_checkout.php

Line 57 in 4ba4b7e

require_once __DIR__ . '/vendor/autoload.php';

Can you provide an example of one module doing it?

https://github.com/PrestaShopCorp/psxmarketingwithgoogle/blob/b92c27de0ee5789b4ef50d171c05b60a0e898b10/psxmarketingwithgoogle.php#L95-L100

[matks]

Hello @Quetzacoalt91 so it took quite a long time but as @L3RAZ investigated, actually it seems PS Checkout v5 is working well with PHP7.1

So I know we have the constraint in composer.json and that theoretically the PHP composer dependencies are marked "PHP7.2" minimum but running the module seems to be correct

So what I am going to do is

• modify the composer.json to acknowledge php7.1 accepted
• run it on a v8 shop too
• verify it works as expected