Fatal error due to null create_time in PayPalOrderResponse (PS Checkout v5.0.2)

[StephaneFerre]

Hello,

I’m encountering a fatal error in ps_checkout v5.0.2:

Warning: Undefined array key "create_time" in PayPalOrderProvider.php on line 167

Fatal error: Uncaught TypeError: PsCheckout\Api\ValueObject\PayPalOrderResponse::__construct(): Argument #8 ($createTime) must be of type string, null given

The error occurs in PayPalOrderProvider.php when calling buildPayPalOrderResponse():

The error occurs in PayPalOrderProvider.php when calling buildPayPalOrderResponse():

private function buildPayPalOrderResponse(array $data): PayPalOrderResponse
{
    return new PayPalOrderResponse(
        $data['id'],
        $data['status'],
        $data['intent'],
        $data['payer'] ?? null,
        $data['payment_source'] ?? null,
        $data['purchase_units'],
        $data['links'],
        $data['create_time'] // <-- can be null, causing fatal error
    );
}

Could you advise whether the PayPalOrderResponse class should allow null for $createTime, or if the provider should always ensure it is set?

Thanks!

[matks]

Hello! Thanks for reporting the bug, we expect create_time to always be set so the fact you got null is not expected.

That is very weird. When we try to reproduce on our side, we have create_time as expected. It might be a bug impacting only you.

I suggest reaching out to the Support team using this link https://help-center.prestashop.com/contact?psx=ps_checkout
because they will be able to verify your specific usecase (your shop, your PrestaShop account, your paypal account) to see if something seems wrong.

[StephaneFerre]

Hello!

Thanks for your quick reply.

To reproduce the issue on my side:

• Log in to the Front Office.

• Go to Order History.

• Click on Order Details for any order placed after the last module update.

Everything worked fine before the latest update. I can still access the order details of all orders placed before the update without any issue.

I have also reproduced this bug on another shop, so it does not seem to be isolated to my installation.

[StephaneFerre]

Hello!

@matks

I applied a temporary fix to avoid the fatal error on one specific order where create_time was null.

In PayPalOrderProvider.php, inside buildPayPalOrderResponse(), I added the following:

// Use created_at if create_time is missing
$createTime` = $data['create_time'] ?? ($data['created_at'] ?? `date('c'));

And then passed $createTime to the PayPalOrderResponse constructor. This allowed me to access the order details without crashing.

Could you advise the proper way to add or set create_time for this order only?
Where should this date ideally be stored so it does not break the provider?

Thanks!

[StephaneFerre]

Hello @matks,

I’m wondering why the module does not include a fallback or safety check for create_time.

In some rare cases, create_time can be null, which causes a fatal error in PayPalOrderProvider.php. Shouldn’t there be a default handling to prevent the provider from crashing when this happens?

This seems like something that could affect more than one user.

Have nice day.

[matks]

Hello @StephaneFerre good news we found the problem! It should be fixed by PR #1381 and delivered with incoming patch release v5.0.4

[StephaneFerre]

Hello @matks 🙂
Thank you so much for the update! I’m really happy you found the problem and fixed it. It’s great to see my small patch was heading in the right direction 😄 Looking forward to trying the official fix in v5.0.4!

[matks]

Fixed in release 5.0.4