[Develop] Mini fixes #291
[Develop] Mini fixes #291
Conversation
- Fix saves on NEON64 - 64DD Detection on Flashcar info - Make saves folder global
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| // Save states in newer versions might require a different save type. | ||
| save_type = FLASHCART_SAVE_TYPE_SRAM_BANKED; | ||
| // Tested against https://github.com/hcs64/neon64v2 | ||
| save_type = FLASHCART_SAVE_TYPE_SRAM_1MBIT; |
There was a problem hiding this comment.
@Suprapote Please can you test this thoroughly, and ensure you update the documentation.
There was a problem hiding this comment.
The last libdragon update on develop branch makes the games don't load (N64, 64DD, NES, SNES, etc), it turns into a black screen
There was a problem hiding this comment.
The issues with ROM loading should now be fixed on the latest commit to develop.
There was a problem hiding this comment.
There was a problem hiding this comment.
Just a note that we need to think about how to handle this change, since saves against the previous emulator get broken, and we cannot trust that users read documentation.
| path_push(path, info.d_name); | ||
| // Skip the "saves" directory if it is hidden (this is case sensitive) | ||
| if (strcmp(info.d_name, "saves") == 0) { // TODO: use SAVES_SUBDIRECTORY from cart_load.c | ||
| if (strcmp(info.d_name, SAVES_SUBDIRECTORY) == 0) { |
There was a problem hiding this comment.
This should be a settings option, rarther than just blindly make it global, as it will both make current users with current folder structure suffer and not be advantagous for some.
There was a problem hiding this comment.
I would rather it be split into a seperate PR.
There was a problem hiding this comment.
Actually, it might be your use of saying "global" (rather than something like use define save sub directory name constant)... Still, seperate PR still stands.
| * @return true if the 64DD is connected, false otherwise. | ||
| */ | ||
| static bool is_64dd_connected (void) { | ||
| bool is_64dd_connected (void) { |
There was a problem hiding this comment.
I have been thinking about this change, and think it is worth while to to ask if physical dd hardware detection can be added to the libdragon SDK. It would be advantagous over this change. Please feel free to suggest it in the N64brew discord.
src/menu/views/browser.c
Outdated
| static const char *n64_rom_extensions[] = { "z64", "n64", "v64", "rom", NULL }; | ||
| static const char *patch_extensions[] = { "bps", "ips", "aps", "ups", "xdelta", NULL }; | ||
| // TODO: "eep", "sra", "srm", "fla" could be used if transfered from different flashcarts. | ||
| static const char *save_extensions[] = { "sav", NULL }; |
There was a problem hiding this comment.
These were TODO as there is no current way to convert them, so users will have invalid saves if loaded from an emu / ED64.
2 participants
Description
Motivation and Context
TODO comments on code
How Has This Been Tested?
Ares emulator
Screenshots
Types of changes
Checklist:
You agree with the license terms and that other license types may be granted with permission of the original
N64FlashcartMenuproject license holders.Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>