PS-9697 C++ KMIP client library added #19
Conversation
lukin-oleksiy
force-pushed
the
PS-9697-POC-of-kmip-cpp
branch
6 times, most recently
from
ecb590a to
38e07d8
Compare
| include/Key.hpp | ||
| src/StringUtils.cpp | ||
| src/StringUtils.hpp | ||
| include/Logger.hpp |
There was a problem hiding this comment.
I am not a CMake expert, but I don't think we should list header files in the list of library files.
There was a problem hiding this comment.
In general case we should. Header files will definitely be used when the CMake project generator is, say, "Visual Studio" or "XCode". For "Linux Makefiles", this may not be the case though as there header dependencies are generated via -MD compiler options. Also, not sure about "Ninja" generator - it may use another approach to generate dependency trees, so there including headers may also be useful.
|
|
||
| } // namespace ve | ||
|
|
||
| #else // C++23 or later |
There was a problem hiding this comment.
Well, I am struggling to understand what is the difference between implementations of expected for the C++ standard is less than C++23 branch and the C++23 or later branch. If such a difference exists, please describe it in the source file as comments.
Why in the first place do we need to implement expected when C++23 is supported? Could we just use an alias template to the std::expected?
| kmipclient::AttributesFactory::parse (Attribute *attribute, size_t attribute_count) | ||
| { | ||
| attributes_t res; | ||
| return res; |
There was a problem hiding this comment.
Seems to be unimplemented?
| int state = 0; | ||
| int secret_type = 0; |
There was a problem hiding this comment.
Please consider changing types for state and secret_type from int to kmip_entity_state and kmip_secret_type respectively.
| ids_t res; | ||
| for (int i = 0; i < locate_result.ids_size; ++i) | ||
| { | ||
| res.emplace_back (locate_result.ids[i]); |
There was a problem hiding this comment.
Seems we have double copying. First, we copy strings pld->unique_ids to locate_result.ids, then - from locate_result.ids to res. Can we eliminated locate_result.ids and copy straight from pld->unique_ids to res?
| else | ||
| last_result.result_message[0] = 0; | ||
|
|
||
| FILE *mem_stream = open_memstream (&bp, &size); |
There was a problem hiding this comment.
Please consider using std::ostringstream instead of FILE* for formatted output.
The "kmipclient" C++ library implementation is added, that wraps low-level "kmip.h" calls and bypasses mid-level "kmip_bio" level.
lukin-oleksiy
force-pushed
the
PS-9697-POC-of-kmip-cpp
branch
from
38e07d8 to
eb16cf2
Compare
The "kmipclient" C++ library implementation is added, that wraps low-level "kmip.h" calls and bypasses mid-level "kmip_bio" level.