Skip to content

Commit e912136

Browse files
committed
fix: streamline custom join data setting in CustomValuesController
1 parent 99a5b17 commit e912136

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Beginning with the updated implementation (post Oct 2025 changes), the plugin in
1414
| 1 | Input | EnableSaving | Hold HIGH to allow persistence of changes. When LOW, saving disabled; if `trackChangesWhileSavingDisabled` is true changes are staged in memory, otherwise ignored. |
1515
| 2 | Output | SavingReadyFb | HIGH when plugin is internally mapped/ready AND EnableSaving asserted. LOW otherwise. |
1616

17-
Control join metadata (capabilities and descriptions) is now declared in the advanced join map (`EssentialsPluginBridgeJoinMapTemplate`). Joins 4 (former re-propagation feedback) was deprecated. Input and output do NOT share join 1; using distinct join 2 for feedback avoids collisions with some bridge pathways that do not permit a single digital to act as both directions simultaneously.
17+
Control join metadata (capabilities and descriptions) is now declared in the advanced join map (`EssentialsPluginBridgeJoinMapTemplate`). Input and output do NOT share join 1; using distinct join 2 for feedback avoids collisions with some bridge pathways that do not permit a single digital to act as both directions simultaneously.
1818

1919
### Digital Join Offset (Data Boolean Join Remapping)
2020
DEFAULTS UPDATED (Oct 2025+): `legacyDigitalJoinBehavior` now defaults to TRUE (you can omit it). When TRUE, boolean data joins are NOT offset and use their configured join numbers relative to `joinStart` (legacy behavior).
@@ -135,7 +135,7 @@ All values can also be set and retrived using the console command "customvalues
135135
```
136136

137137
### Updated Join Mapping Example (Boolean Offset)
138-
If you explicitly set `"legacyDigitalJoinBehavior": false` and `joinStart` is 1, a boolean path configured with `"joinNumber": 1` will map to digital join **101** on the bridge instead of 1. (When the property is omitted or true, it maps directly to join 1.) Control joins 1-4 remain reserved.
138+
If you explicitly set `"legacyDigitalJoinBehavior": false` and `joinStart` is 1, a boolean path configured with `"joinNumber": 1` will map to digital join **101** on the bridge instead of 1. (When the property is omitted or true, it maps directly to join 1.) Control joins 1-2 remain reserved.
139139

140140
### Minimal Config Without File (In-Memory Only)
141141
```json

src/CustomValuesController.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,7 @@ public void LinkToApi(BasicTriList trilist, uint joinStart, string joinMapKey, E
125125
return;
126126
}
127127

128-
if (customJoins != null)
129-
{ joinMap.SetCustomJoinData(customJoins); }
128+
joinMap.SetCustomJoinData(customJoins);
130129

131130
Debug.LogDebug(this, "Linking to Trilist '{0}'", trilist.ID.ToString("X"));
132131
Debug.LogDebug(this, "Linking to Bridge Type {0}", GetType().Name);

0 commit comments

Comments
 (0)