Code review #1
Description
-
In
not missing calling OEntitySystem::update ? -
In
I find sad to set each field this way, this is error-prone (missing one, i.e.) better to use the constructor to pass these parameters: the compiler will warn you in case of missing one. -
In
You use m_entitiesToDestroy for not interfering deleting elements when iterating on them, but why not for createEntityInternal ? I guess you can create entities during the entity->onUpdate ? I guess a fake solution is to use mutex because creating entities at run-time will create a dead lock. But point to take into account when threading your game. Another solution would be unordered_map (confer section Iterator validity https://cplusplus.com/reference/unordered_map/unordered_map/erase/ vs https://cplusplus.com/reference/map/map/erase/) -
Risk of recursivity
entity->onCreate() creating entity calling onCreate() creating entity callin onCreate ... -
In
your destructor does not call release() and release() should be private. -
In
maybe m_entitySystem could be static: no more getEntitySystem()