1.16 support (#1723)

* Update supported HoI4 version

* Update province mappings

* Update modified files through /common/dynamic_modifiers

* Update modifier files through /common

* Finalize blank_mod update

* Blank new country specific files

* Update configurables

* Fix landmarks overriding state naval bases

* Clean up error log

* Update HPM province mappings

* Update PDM province mappings

* Clean up error log

* Fix SufficientDivisionsConvert test

* Fix ConfigurationTests for Windows style paths on Linux

* Remove a stray semicolon

* Roll version

* Add banner

* Update common_items to avoid recursive error

* Update common_items

Author: cetvrtak

.github/workflows/windows_build_test_and_push.yml

@@ -46,12 +46,12 @@ jobs:
     - name: "Prepare release"
       run: |
        cd "C:\Program Files\7-Zip\"
-       .\7z.exe a $Env:GITHUB_WORKSPACE\Vic2ToHoI4-1.3Umberto-II-win-x64.zip $Env:GITHUB_WORKSPACE\build\Release\*
+       .\7z.exe a $Env:GITHUB_WORKSPACE\Vic2ToHoI4-1.4Vasilevsky-win-x64.zip $Env:GITHUB_WORKSPACE\build\Release\*
 
     - name: "Prepare installer"
       run: |
         c:\"Program Files (x86)\Inno Setup 6\iscc" Vic2ToHoI4-Installer.iss
-        cp $Env:GITHUB_WORKSPACE\Output\Vic2ToHoI4-latest-win-x64.exe $Env:GITHUB_WORKSPACE\Output\Vic2ToHoI4-1.3Umberto-II-win-x64.exe
+        cp $Env:GITHUB_WORKSPACE\Output\Vic2ToHoI4-latest-win-x64.exe $Env:GITHUB_WORKSPACE\Output\Vic2ToHoI4-1.4Vasilevsky-win-x64.exe
 
     - name: "Upload binaries to release"
       if: ${{ github.event_name == 'push' }}
@@ -61,7 +61,7 @@ jobs:
         allowUpdates: true
         omitBodyDuringUpdate: true
         omitNameDuringUpdate: true
-        artifacts: Vic2ToHoI4-1.3Umberto-II-win-x64.zip, Output\Vic2ToHoI4-1.3Umberto-II-win-x64.exe
+        artifacts: Vic2ToHoI4-1.4Vasilevsky-win-x64.zip, Output\Vic2ToHoI4-1.4Vasilevsky-win-x64.exe
         token: ${{ secrets.API_TOKEN_GITHUB }}
 
     - name: "Prepare pull request artifact"

Vic2ToHoI4-Installer.iss

@@ -2,7 +2,7 @@
 ; SEE THE DOCUMENTATION FOR DETAILS ON CREATING INNO SETUP SCRIPT FILES!
 
 #define MyAppName "Vic2 to HoI4"
-#define MyAppVersion "1.3 Umberto II"
+#define MyAppVersion "1.4 Vasilevsky"
 #define MyAppPublisher "Paradox Game Converters Group"
 #define MyAppURL "https://paradoxgameconverters.com/"
 #define MyAppExeName "ConverterFrontend.exe"

data/!provincenames_l_english.yml

@@ -12582,4 +12582,5 @@
  PROV13362:0 "Santa Elena de Uairén"
  PROV13363:0 "Kitega"
  PROV13364:0 "Nyanza"
- PROV13365:0 "Nkamba"
+ PROV13365:0 "Nkamba"
+ PROV13369:0 "Khasab"

data/ReadMe.txt

@@ -12,7 +12,7 @@ Development version download: https://github.com/ParadoxGameConverters/Vic2ToHoI
 ----
 REQUIREMENTS
 ----
-HoI4 - 1.15
+HoI4 - 1.16
 V2 - HoD required
 
 

data/blank_mod/common/country_tags/01_countries.txt renamed to data/blank_mod/common/abilities/RAJ_abilities.txt

@@ -275,6 +275,9 @@ ability = {
 		allowed = {
 			has_ability = extra_suplies
 			is_border_war = no
+			OWNER = {
+				NOT = { has_country_flag = has_quinine }
+			}
 		}
 
 		unit_modifiers = {

data/blank_mod/common/abilities/generic_leader_abilities.txt

@@ -2409,3 +2409,89 @@ generic_amphibious_tanks = {
 		}
 	}
 }
+
+
+
+generic_land_cruiser_tanks = {
+	category = land 
+
+	roles = { 
+		land_mega_heavy_breakthrough_tank  
+	}
+
+	priority = {
+		factor = 200
+		modifier = {
+			num_of_factories < 100
+			factor = 0
+		}
+	}
+
+	basic_land_cruiser_default = {
+		target_variant = {
+			match_value = 1000
+			type = land_cruiser_chassis_1
+			modules = {
+				lc_main_armament_slot = lc_heavy_naval_guns
+				lc_secondary_armament_slot = lc_medium_naval_guns
+				lc_special_features_slot_1 = lc_radio_module
+				lc_special_features_slot_2 = empty
+				lc_special_features_slot_3 = empty
+				lc_additional_armament_slot_1 = lc_heavy_naval_guns
+				lc_additional_armament_slot_2 = empty
+				lc_additional_armament_slot_3 = empty
+				lc_additional_armament_slot_4 = empty
+			}
+			upgrades = {
+				tank_nsb_engine_upgrade = 12
+				tank_nsb_armor_upgrade = {
+					base = 10
+					modifier = {
+						add = 5
+						has_war = yes
+					}
+					modifier = {
+						any_enemy_country = {
+							is_major = yes
+						}
+						add = 5
+					}
+				}
+			}
+		}
+
+		allowed_modules = {
+			
+			lc_heavy_naval_guns
+			lc_super_heavy_railway_gun
+			lc_high_impact_obliterator_cannon
+			lc_heavy_anti_air_platform
+			lc_medium_naval_guns
+			lc_hull_mounted_railway_gun
+			lc_super_heavy_howitzer
+			lc_heavy_high_velocity_cannons
+			lc_heavy_anti_air_battery
+			lc_medium_cannon_turret
+			lc_assault_gun
+			lc_high_velocity_cannon_turret
+			lc_light_anti_air_battery
+			lc_flamethrower_turret
+			lc_rocket_launcher
+			lc_radio_1
+			lc_radio_2
+			lc_radio_3
+			lc_command_center
+			lc_radar
+			lc_aircraft_catapult
+			lc_helipad
+			lc_armored_skirts
+			lc_bunker_emplacement
+			lc_obstacle_clearance_gear
+			lc_internal_fuel_tanks
+			lc_internal_ammunition_compartments
+			lc_wet_ammunition_storage
+			lc_smoke_generators
+			lc_stabilizers
+		}
+	}
+}

data/blank_mod/common/ai_equipment/generic_tank.txt

@@ -5,6 +5,7 @@ default_unit_production = {
 	}
 	abort_when_not_enabled = yes
 
+	# Land division factors
 	ai_strategy = {
 		type = role_ratio
 		id = paratroopers
@@ -35,7 +36,7 @@ default_unit_production = {
 		value = 80
 	}
 
-	#Air unit factors
+	# Air unit factors
 	ai_strategy = {
 		type = unit_ratio
 		id = fighter
@@ -128,6 +129,33 @@ default_unit_production = {
 	}
 }
 
+default_unit_production_super_heavies = {
+	enable = {
+		is_major = yes
+		num_of_military_factories > 150 # nly if we have loads of factories
+		date > 1943.6.1 # Lets wait until late war
+		NOT = { has_tech = main_battle_tank_chassis } # Abandon Super heavy projects if we start doing modern tanks instead
+	}
+	abort_when_not_enabled = yes
+	ai_strategy = {
+		type = role_ratio
+		id = super_heavy_breakthrough_role
+		value = 1
+	}
+}
+
+default_unit_production_land_cruiser = {
+	enable = {
+		is_special_project_completed = sp:sp_land_land_cruiser
+	}
+	abort_when_not_enabled = yes
+	ai_strategy = {
+		type = role_ratio
+		id = mega_heavy_breakthrough_role
+		value = 2
+	}
+}
+
 default_role_ratios = {
 	enable = {
 		not = {
@@ -305,7 +333,7 @@ bba_air_prod_1 = {
 		id = cas
 		value = 20 #because doctrine this = 15
 	}
- 
+
 	ai_strategy = {
 		type = unit_ratio
 		id = naval_bomber
@@ -876,15 +904,15 @@ default_market_stockpile_management = {
 	}
 
 	# Better not put all your boats up for sail
-	ai_strategy = {
-		type = equipment_market_for_sale_threshold
-		id = convoy
-		value = 100  # only start considering selling convoys if surplus more than 100
-	}
+	# ai_strategy = {  # Commented because handled dynamically in code through the EQUIPMENT_MARKET_WANTED_CONVOY_USAGE_RATIO define
+	# 	type = equipment_market_for_sale_threshold
+	# 	id = convoy
+	# 	value = 100  # only start considering selling convoys if surplus more than 100
+	# }
 	ai_strategy = {
 		type = equipment_market_min_for_sale
 		id = convoy
-		value = 30  # only put up for sale in chunks of 5
+		value = 20  # only put up for sale in chunks of 20
 	}
 
 	# Don't let all your planes just fly out the window.
@@ -975,7 +1003,7 @@ default_market_convoy_purchases = {
 	ai_strategy = {
 		type = equipment_market_buying_threshold
 		id = convoy
-		value = 30  # Consider buying if we have too few (less than 30) convoys
+		value = 30  # Consider buying if we have too few (less than 30) convoys. Also interacts with the EQUIPMENT_MARKET_WANTED_CONVOY_USAGE_RATIO define.
 	}
 }
 
@@ -1437,10 +1465,10 @@ default_build_a_lw_facility = {
 
 default_build_an_air_facility = {
 	enable = {
-		
+
 		is_major = yes # Minors don't bother until strong enough to be considered major
-		num_of_military_factories > 40 # We should first build up our military industry 
-		
+		num_of_military_factories > 40 # We should first build up our military industry
+
 		OR = { # Don't start until we can build decent aircraft
 			has_tech = basic_small_airframe
 			has_tech = basic_medium_airframe
@@ -1561,7 +1589,7 @@ if_we_can_build_v1_rockets_we_want_rockets = {
 	abort_when_not_enabled = yes
 
 	ai_strategy = {
-		type = equipment_production_min_factories_archetype 
+		type = equipment_production_min_factories_archetype
 		id = guided_missile_equipment
 		value = 1
 	}
@@ -1574,7 +1602,7 @@ if_we_can_build_v2_rockets_we_want_v2_rockets = {
 	abort_when_not_enabled = yes
 
 	ai_strategy = {
-		type = equipment_production_min_factories_archetype 
+		type = equipment_production_min_factories_archetype
 		id = ballistic_missile_equipment
 		value = 1
 	}
@@ -1586,7 +1614,7 @@ if_we_can_build_sams_we_want_sams = {
 	abort_when_not_enabled = yes
 
 	ai_strategy = {
-		type = equipment_production_min_factories_archetype 
+		type = equipment_production_min_factories_archetype
 		id = sam_missile_equipment
 		value = 1
 	}
@@ -1598,7 +1626,7 @@ if_we_can_build_nuclear_missiles_we_want_nuclear_missiles = {
 	abort_when_not_enabled = yes
 
 	ai_strategy = {
-		type = equipment_production_min_factories_archetype 
+		type = equipment_production_min_factories_archetype
 		id = nuclear_missile_equipment
 		value = 1
 	}