[MMU-UI] Memory leak in AuthGuard.canActivate() - unmanaged subscription on every route activation

[lakxy]

Description

AuthGuard.canActivate() calls this.http_service.currentLangugae$.subscribe() on every route activation with no corresponding unsubscribe. AuthGuard is a singleton and currentLangugae$ is a BehaviorSubject that never completes, so each navigation to a protected route adds a subscription that is never released.

The subscribed value current_language_set is never read or used anywhere in the guard logic, so the subscription has no effect at all.

Affected routes (7)

All routes using canActivate: [AuthGuard] in app-routing.module.ts:
/service, /servicePoint, /registrar, /nurse-doctor, /lab, /pharmacist, /datasync

Steps to reproduce

1. Log in and open DevTools -> Memory tab, take a baseline heap snapshot.
2. Navigate between the protected routes above around 10 times.
3. Take a second heap snapshot and compare subscriber counts for currentLangugae$.
4. Subscriber count grows with each navigation and nothing cleans up.

Validation

• currentLangugae$ is new BehaviorSubject(...).asObservable() in http-service.service.ts and never completes, so subscribers are never auto-released.
• current_language_set is only assigned (line 18), never read anywhere in the file.
• No takeUntil, take(1), or unsubscribe() exists in the class.

[amanvaibhav162]

Hello @lakxy Sir,
I’m interested in addressing the memory leak caused by repeated subscriptions in AuthGuard.canActivate().

Issue Understanding:
currentLangugae$ (a BehaviorSubject) is subscribed on every route activation.
Since the guard is a singleton and the observable never completes, subscriptions accumulate.
The subscribed value (current_language_set) is not used, making the subscription redundant.

Proposed Fix:
Remove the unnecessary subscription since it has no impact on guard logic.
Alternatively, if needed in future:
Use take(1) to auto-complete the subscription.
Or refactor using RxJS operators instead of manual subscription.

Plan:
Clean up the redundant code in AuthGuard.
Ensure no memory leaks by avoiding persistent subscriptions.
Test navigation across protected routes to confirm stable subscriber count.

This fix will improve performance and prevent unnecessary memory usage while keeping the guard logic clean.

Please assign me this issue i will solve it and stay connected with you if any changes are requireed

[ayushk687]

@lakxy please assign this issue to me