Ensured that mt_rand() is passed as string to md5. Fixed that the setNewStyle() method could not return style objects as value arguments, when $returnObject is true, like in the Cell element.

Author: hazington

src/PhpWord/Element/AbstractElement.php

@@ -23,6 +23,9 @@
 use PhpOffice\PhpWord\Media;
 use PhpOffice\PhpWord\PhpWord;
 use PhpOffice\PhpWord\Style;
+use PhpOffice\PhpWord\Style\AbstractStyle;
+
+use function is_array;
 
 /**
  * Element abstract class.
@@ -256,7 +259,7 @@ public function getElementId()
      */
     public function setElementId(): void
     {
-        $this->elementId = substr(md5(mt_rand()), 0, 6);
+        $this->elementId = substr(md5((string) mt_rand()), 0, 6);
     }
 
     /**
@@ -481,22 +484,24 @@ public function isInSection()
     /**
      * Set new style value.
      *
-     * @param mixed $styleObject Style object
-     * @param null|array|string|Style $styleValue Style value
+     * @param AbstractStyle $styleObject Style object
+     * @param null|string|array|AbstractStyle $styleValue Style value
      * @param bool $returnObject Always return object
      *
-     * @return mixed
+     * @return null|string|array|AbstractStyle
      */
     protected function setNewStyle($styleObject, $styleValue = null, $returnObject = false)
     {
-        if (null !== $styleValue && is_array($styleValue)) {
+        if ($styleValue instanceof AbstractStyle && get_class($styleValue) === get_class($styleObject)) {
+            return clone $styleValue;
+        }
+
+        if (is_array($styleValue)) {
             $styleObject->setStyleByArray($styleValue);
-            $style = $styleObject;
-        } else {
-            $style = $returnObject ? $styleObject : $styleValue;
+            return $styleObject;
         }
 
-        return $style;
+        return $returnObject === true ? $styleObject : $styleValue;
     }
 
     /**