-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
GameDB: SFOS fixes #13460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
GameDB: SFOS fixes #13460
Conversation
SCES-52033: Fixed "Cop2 problems." code that. Second address was wrong and was producing a bug (PCSX2#7513) SCUS-97264: added fixes for Review Prototype (cop2, other languages) SCUS-97397: added fixes (cop2, offline button) TCES-52033: added fixes (cop2, offline button)
F0bes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
We found that SCUS-97397 is a prototype according to redump.
We don't support those in the gamedb. Would you be able to remove the entire entry for it?
Thanks again.
bin/resources/GameIndex.yaml
Outdated
| author=YukiXXL | ||
| // Cop2 problems. | ||
| patch=0,EE,0038E8E8,word,48438000 | ||
| patch=0,EE,0036CC9C,word,4B06521B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you make the same error I did here? distance is similarly different from the other patches (and correction).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ups. Just now noticed it. Sorry.
bin/resources/GameIndex.yaml
Outdated
| // Cop2 problems. | ||
| patch=0,EE,0038E8E8,word,48438000 | ||
| patch=0,EE,0036CC9C,word,4B06521B | ||
| // Offline button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this offline button?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The game is only playable online due to offline button being greyed out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that means what I think it does, enabling the Offline button should be an optional patch rather than something enforced by the DB. The DB is meant to fix bugs with PCSX2's emulation of a serial, not alter its original intended gameplay experience.
That is not a prototype but Public Beta which was sent to many players. Redump entry needs correction. |
|
We had a look at these, checks out that it was a public release. |
TheTechnician27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the offline patches and submit them as optional patches in the pcsx2_patches repo. The DB is meant to fix bugs with PCSX2's emulation of a serial, not alter its original intended gameplay experience. These public betas were not meant by the developers to have this button; this is not a bug on our part or theirs.
|
@YukiXXL Update on this? |
Done. I think. |
|
Description of Changes
SCES-52033:
Fixed "Cop2 problems." code that. Second address was wrong and was producing a bug (#7513)
SCUS-97264:
added fixes for Review Prototype (cop2, other languages)
SCUS-97397:
added fixes (cop2, offline button)
TCES-52033:
added fixes (cop2, offline button)
Rationale behind Changes
Fixed issue #7513 . Fixed flashlights and night visions. Fixed game not being playable offline.
Did you use AI to help find, test, or implement this issue or feature?
No.