Skip to content

Conversation

@YukiXXL
Copy link

@YukiXXL YukiXXL commented Oct 28, 2025

Description of Changes

SCES-52033:
Fixed "Cop2 problems." code that. Second address was wrong and was producing a bug (#7513)

SCUS-97264:
added fixes for Review Prototype (cop2, other languages)

SCUS-97397:
added fixes (cop2, offline button)

TCES-52033:
added fixes (cop2, offline button)

Rationale behind Changes

Fixed issue #7513 . Fixed flashlights and night visions. Fixed game not being playable offline.

Did you use AI to help find, test, or implement this issue or feature?

No.

SCES-52033:
Fixed "Cop2 problems." code that. Second address was wrong and was producing a bug (PCSX2#7513)

SCUS-97264:
added fixes for Review Prototype (cop2, other languages)

SCUS-97397:
added fixes (cop2, offline button)

TCES-52033:
added fixes (cop2, offline button)
@YukiXXL YukiXXL changed the title GameDB - SFOS GameDB: SFOS fixes Oct 28, 2025
F0bes
F0bes previously requested changes Oct 29, 2025
Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
We found that SCUS-97397 is a prototype according to redump.
We don't support those in the gamedb. Would you be able to remove the entire entry for it?

Thanks again.

author=YukiXXL
// Cop2 problems.
patch=0,EE,0038E8E8,word,48438000
patch=0,EE,0036CC9C,word,4B06521B
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make the same error I did here? distance is similarly different from the other patches (and correction).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups. Just now noticed it. Sorry.

// Cop2 problems.
patch=0,EE,0038E8E8,word,48438000
patch=0,EE,0036CC9C,word,4B06521B
// Offline button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this offline button?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The game is only playable online due to offline button being greyed out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that means what I think it does, enabling the Offline button should be an optional patch rather than something enforced by the DB. The DB is meant to fix bugs with PCSX2's emulation of a serial, not alter its original intended gameplay experience.

@YukiXXL
Copy link
Author

YukiXXL commented Oct 29, 2025

Thanks for the PR. We found that SCUS-97397 is a prototype according to redump. We don't support those in the gamedb. Would you be able to remove the entire entry for it?

Thanks again.

That is not a prototype but Public Beta which was sent to many players. Redump entry needs correction.

@RedPanda4552 RedPanda4552 dismissed F0bes’s stale review October 29, 2025 17:10

Requested by fobes cause he busy

@RedPanda4552
Copy link
Contributor

We had a look at these, checks out that it was a public release.

Copy link
Contributor

@TheTechnician27 TheTechnician27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the offline patches and submit them as optional patches in the pcsx2_patches repo. The DB is meant to fix bugs with PCSX2's emulation of a serial, not alter its original intended gameplay experience. These public betas were not meant by the developers to have this button; this is not a bug on our part or theirs.

@lightningterror
Copy link
Contributor

@YukiXXL Update on this?

@YukiXXL
Copy link
Author

YukiXXL commented Nov 23, 2025

@YukiXXL Update on this?

Done. I think.

@TheTechnician27
Copy link
Contributor

TheTechnician27 commented Nov 27, 2025

  • We'll want to squash these three commits before merge, as one is just a rebase while another removes a patch introduced by the first commit.
  • I'm not sure what the protocol is for patches for obscure titles like this. Assume the patch creator did their due dilligence and revisit it if someone reports a problem?
  • Also, suggest removing "Fixed game not being playable offline." from the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants