Allow users of CMOR to override long_name from tables

[matthew-mizielinski]

There has been some discussion on the WIP about overriding the the use of long names when writing data for CMIP7. At present this does not appear to be possible with CMOR as the variable() routine does not allow this field to be specified via a keyword argument and set_variable_attribute() is not allowed to override it.

Would it be acceptable to allow the user to override long_name variable attributes when writing data?

If I'm reading the code correctly then this would simply require the removal of the following line from the set_variable_attribute routine;

cmor/Src/cmor_variables.c

Line 208 in cb5066b

(strcmp(attribute_name, VARIABLE_ATT_LONGNAME) == 0) ||

@taylor13 @durack1 @JamesAnstey thoughts welcome

[mauzey1]

I agree that the error message is confusing since it suggests that the attribute can be set via the call to cmor_variable when it should really mean that the attribute value comes from the table when cmor_variable is called.