Some constexpr cleanup

Author: hhvrc

include/Chipset.h

@@ -281,8 +281,8 @@ namespace OpenShock {
     return count;
   }
 
-  const uint8_t ValidInputPinsCount  = GetValidInputPinsCount();
-  const uint8_t ValidOutputPinsCount = GetValidOutputPinsCount();
+  constexpr uint8_t ValidInputPinsCount  = GetValidInputPinsCount();
+  constexpr uint8_t ValidOutputPinsCount = GetValidOutputPinsCount();
   typedef std::bitset<GPIO_NUM_MAX> GPIOPinSet;
 
   constexpr GPIOPinSet GetValidGPIOPins()

include/GatewayClient.h

@@ -19,7 +19,7 @@ namespace OpenShock {
     GatewayClient(const std::string& authToken);
     ~GatewayClient();
 
-    constexpr GatewayClientState state() const { return m_state; }
+    inline GatewayClientState state() const { return m_state; }
 
     void connect(const char* lcgFqdn);
     void disconnect();

src/SemVer.cpp

@@ -154,12 +154,15 @@ constexpr bool _semverIsDotSeperatedPreleaseIdentifiers(std::string_view str)
 
   return _semverIsPrereleaseIdentifier(str);
 }
-const auto _semverIsPatch      = _semverIsNumericIdentifier;
-const auto _semverIsMinor      = _semverIsNumericIdentifier;
-const auto _semverIsMajor      = _semverIsNumericIdentifier;
-const auto _semverIsPrerelease = _semverIsDotSeperatedPreleaseIdentifiers;
-const auto _semverIsBuild      = _semverIsDotSeperatedBuildIdentifiers;
-bool _semverIsVersionCore(std::string_view str)
+
+// For readability
+#define _semverIsPatch      _semverIsNumericIdentifier
+#define _semverIsMinor      _semverIsNumericIdentifier
+#define _semverIsMajor      _semverIsNumericIdentifier
+#define _semverIsPrerelease _semverIsDotSeperatedPreleaseIdentifiers
+#define _semverIsBuild      _semverIsDotSeperatedBuildIdentifiers
+
+constexpr bool _semverIsVersionCore(std::string_view str)
 {
   if (str.empty()) {
     return false;
@@ -172,7 +175,7 @@ bool _semverIsVersionCore(std::string_view str)
 
   return _semverIsMajor(parts[0]) && _semverIsMinor(parts[1]) && _semverIsPatch(parts[2]);
 }
-bool _semverIsSemver(std::string_view str)
+constexpr bool _semverIsSemver(std::string_view str)
 {
   if (str.empty()) {
     return false;