Repository navigation
Conversation
cgorantla
force-pushed
the
cg/jira/NMS-19137
branch
from
March 27, 2026 18:08
b0cca1b to
a8ad37d
Compare
marshallmassengill
self-requested a review
September 2, 2026 13:41
marshallmassengill
requested changes
Sep 2, 2026
marshallmassengill
left a comment
Contributor
There was a problem hiding this comment.
Two Blockers
- A retried pass can hide tests that never ran. With retries on, the first pass uses --fail-at-end, which skips every module depending on a failed one. The retry re-runs only the failed classes, so the skipped modules' tests never execute and the job goes green. Reproduced with surefire 3.2.5: a genuinely broken test in a dependent module never ran, final exit 0. Fix: first pass with --fail-never, derive the failure signal from the report scan instead of Maven's exit code.
- Flaky evidence is destroyed. The retry deletes the failing TEST-*.xml before re-running, so uploaded results and Test Insights only ever see the passing retry. Reproduced: the only report left afterwards has failures="0". Develop fixed this in PR 8404 (NMS-19648, merged 2026-04-10); foundation-2024 has none of it. Fold in the itest.sh, smoke.sh, and yml hunks from 8404 or land them immediately after.
Some other things we may want to address:
- The enlinkd log4j2-test.xml is a dead file.
- Systemic failures now cost a full run plus a full retry. Dropping -Dfailsafe.skipAfterFailureCount=1 means a dead Postgres or Docker runs every IT to failure, then reruns them all. This may be intentional.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR back ports #8362
and #8382
External References