Cache ResultSet metadata and use 1-based indexing to avoid per-row metadata lookups

Cache ResultSetMetaData (column count, types, and names) before iterating rows and switch to 1-based arrays/loops so resultSet getters can be called directly with the column index. This prevents repeated getColumnType/getColumnName calls for every row and reduces per-row metadata lookups when building connector metadata maps.

Signed-off-by: Nico Piel <nico.piel@hotmail.de>

Author: NicoPiel

donkey/src/main/java/com/mirth/connect/donkey/server/data/jdbc/JdbcDao.java

@@ -2937,11 +2937,11 @@ private Map<Long, Map<Integer, Map<String, Object>>> getMetaDataMaps(String chan
 
             ResultSetMetaData resultSetMetaData = resultSet.getMetaData();
             int columnCount = resultSetMetaData.getColumnCount();
-            MetaDataColumnType[] columnTypes = new MetaDataColumnType[columnCount];
-            String[] columnNames = new String[columnCount];
-            for (int i = 0; i < columnCount; i++) {
-                columnTypes[i] = MetaDataColumnType.fromSqlType(resultSetMetaData.getColumnType(i + 1));
-                columnNames[i] = resultSetMetaData.getColumnName(i + 1).toUpperCase();
+            MetaDataColumnType[] columnTypes = new MetaDataColumnType[columnCount + 1];
+            String[] columnNames = new String[columnCount + 1];
+            for (int i = 1; i <= columnCount; i++) {
+                columnTypes[i] = MetaDataColumnType.fromSqlType(resultSetMetaData.getColumnType(i));
+                columnNames[i] = resultSetMetaData.getColumnName(i).toUpperCase();
             }
 
             while (resultSet.next()) {
@@ -2960,13 +2960,12 @@ private Map<Long, Map<Integer, Map<String, Object>>> getMetaDataMaps(String chan
                     connectorMetaDataMap.put(metaDataId, metaDataMap);
                 }
 
-                for (int i = 0; i < columnCount; i++) {
+                for (int i = 1; i <= columnCount; i++) {
                     Object value = null;
-                    int colIndex = i + 1;
 
                     switch (columnTypes[i]) {//@formatter:off
                         case STRING:
-                            value = resultSet.getString(colIndex);
+                            value = resultSet.getString(i);
                             if (encryptor != null && StringUtils.startsWith((String) value, Encryptor.HEADER_INDICATOR)) {
                                 try {
                                     value = encryptor.decrypt((String) value);
@@ -2975,11 +2974,11 @@ private Map<Long, Map<Integer, Map<String, Object>>> getMetaDataMaps(String chan
                                 }
                             }
                             break;
-                        case NUMBER: value = resultSet.getBigDecimal(colIndex); break;
-                        case BOOLEAN: value = resultSet.getBoolean(colIndex); break;
+                        case NUMBER: value = resultSet.getBigDecimal(i); break;
+                        case BOOLEAN: value = resultSet.getBoolean(i); break;
                         case TIMESTAMP:
 
-                            Timestamp timestamp = resultSet.getTimestamp(colIndex);
+                            Timestamp timestamp = resultSet.getTimestamp(i);
                             if (timestamp != null) {
                                 value = Calendar.getInstance();
                                 ((Calendar) value).setTimeInMillis(timestamp.getTime());