Skip to content

Commit 30eef4a

Browse files
committed
try/finally scope for tailers & appenders in tests
1 parent c5e4e50 commit 30eef4a

File tree

3 files changed

+21
-21
lines changed

3 files changed

+21
-21
lines changed

src/test/java/net/openhft/chronicle/queue/SingleChroniclePerfMainTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ static void doPerfTest(TestWriter<Bytes<?>> writer, TestReader<Bytes<?>> reader,
6363
Histogram readHdr = new Histogram(30, 7);
6464
String file = OS.getTarget() + "/deleteme-" + Time.uniqueId();
6565
try (ChronicleQueue chronicle = single(file).blockSize(64 << 20).build();
66-
ExcerptAppender appender = chronicle.createAppender()) {
66+
ExcerptAppender appender = chronicle.createAppender();
67+
ExcerptTailer tailer = chronicle.createTailer()) {
6768
UncheckedBytes bytes = new UncheckedBytes(NoBytesStore.NO_BYTES);
6869
for (int i = 0; i < count; i++) {
6970
long start = System.nanoTime();
@@ -79,7 +80,6 @@ static void doPerfTest(TestWriter<Bytes<?>> writer, TestReader<Bytes<?>> reader,
7980
writeHdr.sample(time);
8081
}
8182

82-
ExcerptTailer tailer = chronicle.createTailer();
8383
for (int i = 0; i < count; i++) {
8484
long start2 = System.nanoTime();
8585
try (DocumentContext dc = tailer.readingDocument()) {

src/test/java/net/openhft/chronicle/queue/StridingAQueueTest.java

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -46,22 +46,23 @@ public void testStriding() {
4646

4747
assertEquals(getExpected(), queue.dump().replaceAll("(?m)^#.+$\\n", ""));
4848
StringWriter sw = new StringWriter();
49-
ExcerptTailer tailer = queue.createTailer().direction(TailerDirection.BACKWARD).toEnd().striding(true);
50-
MethodReader reader = tailer.methodReader(Mocker.logging(SAQMessage.class, "", sw));
51-
while (reader.readOne()) ;
52-
assertEquals("hi[4, 9]\n" +
53-
"hi[4, 8]\n" +
54-
"hi[4, 4]\n" +
55-
"hi[4, 0]\n" +
56-
"hi[3, 8]\n" +
57-
"hi[3, 4]\n" +
58-
"hi[3, 0]\n" +
59-
"hi[2, 7]\n" +
60-
"hi[2, 5]\n" +
61-
"hi[2, 1]\n" +
62-
"hi[1, 4]\n" +
63-
"hi[1, 0]\n",
64-
sw.toString().replace("\r", ""));
49+
try (ExcerptTailer tailer = queue.createTailer().direction(TailerDirection.BACKWARD).toEnd().striding(true)) {
50+
MethodReader reader = tailer.methodReader(Mocker.logging(SAQMessage.class, "", sw));
51+
while (reader.readOne()) ;
52+
assertEquals("hi[4, 9]\n" +
53+
"hi[4, 8]\n" +
54+
"hi[4, 4]\n" +
55+
"hi[4, 0]\n" +
56+
"hi[3, 8]\n" +
57+
"hi[3, 4]\n" +
58+
"hi[3, 0]\n" +
59+
"hi[2, 7]\n" +
60+
"hi[2, 5]\n" +
61+
"hi[2, 1]\n" +
62+
"hi[1, 4]\n" +
63+
"hi[1, 0]\n",
64+
sw.toString().replace("\r", ""));
65+
}
6566
}
6667
}
6768

src/test/java/net/openhft/chronicle/queue/WriteReadTextTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,8 @@ private void doTest(@NotNull String... problematic) {
8181
.blockSize(Maths.nextPower2(EXTREMELY_LARGE.length() * 4, 256 << 10))
8282
// .testBlockSize() not suitable as large message sizes.
8383
.build();
84-
ExcerptAppender appender = theQueue.createAppender()) {
85-
86-
ExcerptTailer tailer = theQueue.createTailer();
84+
ExcerptAppender appender = theQueue.createAppender();
85+
ExcerptTailer tailer = theQueue.createTailer()) {
8786

8887
StringBuilder tmpReadback = new StringBuilder();
8988

0 commit comments

Comments
 (0)