crypto: api - Disallow identical driver names

herbertx · gregkh · commit b1a67a0d1ace · 2024-01-31T16:18:49.000-08:00
commit 27016f75f5ed47e2d8e0ca75a8ff1f40bc1a5e27 upstream.

Disallow registration of two algorithms with identical driver names.

Cc: &lt;stable@vger.kernel.org&gt;
Reported-by: Ovidiu Panait &lt;ovidiu.panait@windriver.com&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/crypto/algapi.c b/crypto/algapi.c
@@ -341,6 +341,7 @@ __crypto_register_alg(struct crypto_alg *alg, struct list_head *algs_to_put)
 		}
 
 		if (!strcmp(q->cra_driver_name, alg->cra_name) ||
+		    !strcmp(q->cra_driver_name, alg->cra_driver_name) ||
 		    !strcmp(q->cra_name, alg->cra_driver_name))
 			goto err;
 	}

Original file line number	Diff line number	Diff line change
`@@ -341,6 +341,7 @@ __crypto_register_alg(struct crypto_alg alg, struct list_head algs_to_put)`
`341`	`341`	`}`
`342`	`342`
`343`	`343`	`if (!strcmp(q->cra_driver_name, alg->cra_name) \|\|`
	`344`	`+ !strcmp(q->cra_driver_name, alg->cra_driver_name) \|\|`
`344`	`345`	`!strcmp(q->cra_name, alg->cra_driver_name))`
`345`	`346`	`goto err;`
`346`	`347`	`}`