Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Handle ltc address error from blockbook #1678

Open
@cpacia

Description

@cpacia

If a regular litcoin address starts with ltc1 blockbook will error because it tries to parse it as a segwit address. This causes all address queries to fail as the query is batched.

Out path forward is to:

  • Log the error and continue. Other errors should continue to behave as current.

  • Create a way to push errors into ob-go so they can be pushed up to the UI. This would be used when an invalid address is detected with a balance.

This approach would probably be an additional errors field in the JSON response to GET /wallet/balance. The client would use this error to add information to the UI regarding problems concerning the shown balance per currency. Example:

{
    "BCH": {
        "confirmed": 0,
        "height": 595764,
        "unconfirmed": 0
    },
    "BTC": {
        "confirmed": 0,
        "height": 590091,
        "unconfirmed": 0
    },
    "LTC": {
        "confirmed": 0,
        "height": 1684945,
        "unconfirmed": 0
    },
    "ZEC": {
        "confirmed": 0,
        "height": 585224,
        "unconfirmed": 0
    },
    "errors": ["A problem was detected with LTC", "Another error returned by the wallet"],
}

Metadata

Metadata

Assignees

Labels

featureFeature or enhancement to openbazaar-gohacktoberfestGood tasks for participation in https://hacktoberfest.digitalocean.com/help wantedorderingordering issues

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions