Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Extract GETOrder behavior into unit testable method #1483

Open
Open
Extract GETOrder behavior into unit testable method#1483
Labels
beginnerGood issue to get feet wetfeatureFeature or enhancement to openbazaar-go
@placer14

Description

@placer14
placer14
opened on Mar 5, 2019
Member

The behavior within GETOrder is complex and untestable while embedded within the API. Need to extract behavior into (perhaps) core/order.go as func (*OpenBazaarNode) GetOrder(orderID string) (*repo.Order, error) and unit test the output state of *repo.Order for various valid states of Order. (With particular care to validate this bug does not regress: #1481)

Activity

placer14
added
featureFeature or enhancement to openbazaar-go
beginnerGood issue to get feet wet
on Mar 5, 2019
placer14
added a commit that references this issue on Aug 20, 2019

Merge pull request #1682 from ozamiatin/master

e225593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    beginnerGood issue to get feet wetfeatureFeature or enhancement to openbazaar-go

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @placer14

        Issue actions
          Extract GETOrder behavior into unit testable method · Issue #1483 · OpenBazaar/openbazaar-go