Error on compiling due to ciso646 usage

[hockeymikey]

/usr/include/c++/15.1.1/ciso646:46:4: error: #warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros" [-Werror=cpp] 46 | # warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros" | ^~~~~~~ cc1plus: all warnings being treated as errors

Pretty self explanatory. Building this on Arch using the AUR package. Errors are due to usage in OcTreeKey.h and Pointcloud.cpp.

[gfadini]

Hi @hockeymikey I also had the same issue. In newer c++ standards it seems ciso646 should be replaced by version #include <ciso646> -> #include <version>. I found a similar issue here

[ahornung]

Thanks! I can't reproduce locally unfortunately, but that makes sense. Two findings:

• to avoid warnings like these, I'm tempted to remove the "-Werror" option again (see https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend/ )
• That whole function using the compiler specific switches subSampleRandom(...) is not even used in the code - could be removed as well