Update event sync process: fix KeyError 'start-date'

Author: arkid15r

backend/apps/owasp/management/commands/owasp_enrich_events.py

@@ -40,7 +40,7 @@ def handle(self, *args, **options) -> None:
             if not event.suggested_location and (
                 prompt := Prompt.get_owasp_event_suggested_location()
             ):
-                event.generate_suggested_location(prompt)
+                event.generate_suggested_location(prompt=prompt)
 
             # Geo location.
             if not event.latitude or not event.longitude:

backend/apps/owasp/management/commands/owasp_update_events.py

@@ -20,8 +20,9 @@ def handle(self, *args, **kwargs) -> None:
 
         Event.bulk_save(
             [
-                Event.update_data(category["category"], event_data)
+                event
                 for category in data
                 for event_data in category["events"]
+                if (event := Event.update_data(category["category"], event_data, save=False))
             ]
         )

backend/apps/owasp/models/event.py

@@ -4,6 +4,8 @@
 
 from typing import TYPE_CHECKING
 
+from apps.core.models.prompt import Prompt
+
 if TYPE_CHECKING:  # pragma: no cover
     from datetime import date
 
@@ -144,7 +146,7 @@ def parse_dates(dates: str, start_date: date) -> date | None:
         return None
 
     @staticmethod
-    def update_data(category, data, *, save: bool = True) -> Event:
+    def update_data(category, data, *, save: bool = True) -> Event | None:
         """Update event data.
 
         Args:
@@ -162,7 +164,11 @@ def update_data(category, data, *, save: bool = True) -> Event:
         except Event.DoesNotExist:
             event = Event(key=key)
 
-        event.from_dict(category, data)
+        try:
+            event.from_dict(category, data)
+        except KeyError:  # No start date.
+            return None
+
         if save:
             event.save()
 
@@ -179,18 +185,19 @@ def from_dict(self, category: str, data: dict) -> None:
             None
 
         """
+        start_date = data["start-date"]
         fields = {
             "category": {
                 "AppSec Days": Event.Category.APPSEC_DAYS,
                 "Global": Event.Category.GLOBAL,
                 "Partner": Event.Category.PARTNER,
             }.get(category, Event.Category.OTHER),
             "description": data.get("optional-text", ""),
-            "end_date": Event.parse_dates(data.get("dates", ""), data["start-date"]),
+            "end_date": Event.parse_dates(data.get("dates", ""), start_date),
             "name": data["name"],
-            "start_date": parser.parse(data["start-date"]).date()
-            if isinstance(data["start-date"], str)
-            else data["start-date"],
+            "start_date": parser.parse(start_date).date()
+            if isinstance(start_date, str)
+            else start_date,
             "url": normalize_url(data.get("url", "")) or "",
         }
 
@@ -213,7 +220,7 @@ def generate_geo_location(self) -> None:
             self.latitude = location.latitude
             self.longitude = location.longitude
 
-    def generate_suggested_location(self, prompt) -> None:
+    def generate_suggested_location(self, prompt=None) -> None:
         """Generate a suggested location for the event.
 
         Args:
@@ -225,7 +232,9 @@ def generate_suggested_location(self, prompt) -> None:
         """
         open_ai = OpenAi()
         open_ai.set_input(self.get_context())
-        open_ai.set_max_tokens(100).set_prompt(prompt)
+        open_ai.set_max_tokens(100).set_prompt(
+            prompt or Prompt.get_owasp_event_suggested_location()
+        )
         try:
             suggested_location = open_ai.complete()
             self.suggested_location = (
@@ -234,7 +243,7 @@ def generate_suggested_location(self, prompt) -> None:
         except (ValueError, TypeError):
             self.suggested_location = ""
 
-    def generate_summary(self, prompt) -> None:
+    def generate_summary(self, prompt=None) -> None:
         """Generate a summary for the event.
 
         Args:
@@ -246,7 +255,7 @@ def generate_summary(self, prompt) -> None:
         """
         open_ai = OpenAi()
         open_ai.set_input(self.get_context(include_dates=True))
-        open_ai.set_max_tokens(100).set_prompt(prompt)
+        open_ai.set_max_tokens(100).set_prompt(prompt or Prompt.get_owasp_event_summary())
         try:
             summary = open_ai.complete()
             self.summary = summary if summary and summary != "None" else ""