Skip to content

Allow passProps type parameter to be used with Layout in ShowModalCommand #60

Description

@dyerw

The PushCommand show here allows the parameter P to specify the passProps type but it's not parameterized similarly in ShowModalCommand. I would like to validate my props when using the ShowModalCommand and I believe it just needs to be updated to a similar type. Thanks!

interface PushCommand {
    <P = {}>(layout: Layout<P>): Promise<any>;
    (name: string): Promise<any>;
    <P = {}>(name: string, passProps?: P): Promise<any>;
    <P = {}>(name: string, passProps?: P, options?: Options): Promise<any>;
}
interface ShowModalCommand {
    (layout: Layout): Promise<any>;
    <P = {}>(name: string, passProps?: P, options?: Options): Promise<any>;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions