add PKCE option to kubelogin POC #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lentzi90
reviewed
May 12, 2025
tuminoid
force-pushed
the
tuomo/update-kubelogin-to-use-pkce
branch
2 times, most recently
from
3d1a095 to
97ae8ff
Compare
Add device-code flow with PKCE to Kubelogin POC. Signed-off-by: Tuomo Tanskanen <[email protected]>
tuminoid
force-pushed
the
tuomo/update-kubelogin-to-use-pkce
branch
from
97ae8ff to
00e3d0d
Compare
Member
Author
|
Thanks for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add device-code flow with PKCE to Kubelogin POC.