Skip to content

Commit 6e0259e

Browse files
tuminoidmetal3-io-bot
authored andcommitted
update kubelogin-poc to include offline_access
Update Kubelogin POC to include offline_access scope for enabling refresh tokens. Especially device-code flow is annoying if the idToken would expire as it would lead to another browser login. Also cleanup the kubeconfig example to use real values from run.sh for device-code flow. Signed-off-by: Tuomo Tanskanen <[email protected]>
1 parent 1eeacc5 commit 6e0259e

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

security/kubelogin-poc/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,8 @@ look like:
132132
- --oidc-extra-scope=email
133133
- --oidc-extra-scope=profile
134134
- --oidc-extra-scope=groups
135+
# if you want to use refresh tokens, add offline_access scope
136+
- --oidc-extra-scope=offline_access
135137
- --grant-type=password
136138
- --insecure-skip-tls-verify
137139
```
@@ -194,6 +196,8 @@ to look like:
194196
- --oidc-extra-scope=email
195197
- --oidc-extra-scope=profile
196198
- --oidc-extra-scope=groups
199+
# if you want to use refresh tokens, add offline_access scope
200+
- --oidc-extra-scope=offline_access
197201
- --insecure-skip-tls-verify
198202
- --use-device-code
199203
```

security/kubelogin-poc/kubeconfig.device-code.example

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ users:
2727
- get-token
2828
- --oidc-issuer-url=https://dex.example.com:32000
2929
- --oidc-client-id=kubelogin-test
30-
# - --oidc-client-secret=kubelogin-test-secret
3130
- --oidc-pkce-method=S256
3231
- --oidc-extra-scope=email
3332
- --oidc-extra-scope=profile
3433
- --oidc-extra-scope=groups
35-
# - --grant-type=password
34+
- --oidc-extra-scope=offline_access
35+
- --oidc-pkce-method=S256
36+
- --grant-type=device-code
3637
- --insecure-skip-tls-verify
37-
- --use-device-code
3838
# enable verbose logs
3939
- -v1
4040
command: kubectl

security/kubelogin-poc/kubeconfig.password.example

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ users:
3131
- --oidc-extra-scope=email
3232
- --oidc-extra-scope=profile
3333
- --oidc-extra-scope=groups
34+
- --oidc-extra-scope=offline_access
3435
- --grant-type=password
3536
- --insecure-skip-tls-verify
3637
# enable verbose logs

security/kubelogin-poc/run.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ if [[ "${TYPE}" == "password" ]]; then
5757
--exec-arg=--oidc-extra-scope=email \
5858
--exec-arg=--oidc-extra-scope=profile \
5959
--exec-arg=--oidc-extra-scope=groups \
60+
--exec-arg=--oidc-extra-scope=offline_access \
6061
--exec-arg=--insecure-skip-tls-verify \
6162
--exec-arg=--oidc-client-secret=kubelogin-test-secret \
6263
--exec-arg=--grant-type=password \
@@ -72,6 +73,7 @@ else
7273
--exec-arg=--oidc-extra-scope=email \
7374
--exec-arg=--oidc-extra-scope=profile \
7475
--exec-arg=--oidc-extra-scope=groups \
76+
--exec-arg=--oidc-extra-scope=offline_access \
7577
--exec-arg=--insecure-skip-tls-verify \
7678
--exec-arg=--oidc-pkce-method=S256 \
7779
--exec-arg=--grant-type=device-code \

0 commit comments

Comments
 (0)