-
Notifications
You must be signed in to change notification settings - Fork 27
LLT-6647: Use libfirewall.so #1566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stalowyjez
wants to merge
12
commits into
main
Choose a base branch
from
LLT-6647-use_libfirewall
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,603
−6,123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73ad664 to
a1dd30e
Compare
Since it's a generated file, it doesn't make sense to complain about too long function or unused variable.
e84422e to
3449633
Compare
3449633 to
e97d8d9
Compare
a9c4f30 to
9e04ce8
Compare
2e519e4 to
ea4dbac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Libtelio should use dynamically loaded libfirewall.so library
Solution
Add loader, load firewall library and use it instead of the implementation inside
telio-firewall, which this PR removes.☑️ Definition of Done checklist