chore: Memory leaks

Author: dtkav

src/Document.ts

@@ -160,11 +160,15 @@ export class Document extends HasProvider implements IFile, HasMimeType {
 	}
 	public get tfile(): TFile | null {
 		if (!this._tfile) {
-			this._tfile = this._parent.getTFile(this);
+			this._tfile = this.getTFile();
 		}
 		return this._tfile;
 	}
 
+	getTFile(): TFile | null {
+		return this._parent.getTFile(this);
+	}
+
 	public get ytext(): Y.Text {
 		return this.ydoc.getText("contents");
 	}
@@ -463,6 +467,7 @@ export class Document extends HasProvider implements IFile, HasMimeType {
 		this.whenSyncedPromise = null as any;
 		this.readyPromise?.destroy();
 		this.readyPromise = null as any;
+		this._parent = null as any;
 	}
 
 	public async read(): Promise<string> {

src/LiveViews.ts

@@ -116,6 +116,7 @@ export class LoggedOutView implements S3View {
 
 	destroy() {
 		this.release();
+		this.banner?.destroy();
 		this.banner = undefined;
 		this.view = null as any;
 	}

src/markdownView/InvalidLinkExtension.ts

@@ -8,7 +8,7 @@ import {
 } from "@codemirror/view";
 import { WidgetType } from "@codemirror/view";
 import {
-    LiveView,
+	LiveView,
 	LiveViewManager,
 	ConnectionManagerStateField,
 } from "../LiveViews";
@@ -87,11 +87,10 @@ export class InvalidLinkPluginValue {
 
 		if (this.view.document) {
 			this.view.document.whenSynced().then(() => {
-				if (this.connectionManager && this.app && this.view?.document?.tfile) {
-					this.connectionManager.onMeta(this.view.document.tfile, this.cb);
-					const fileCache = this.app.metadataCache.getFileCache(
-						this.view.document.tfile,
-					);
+				const tfile = this.view?.document?.getTFile();
+				if (this.connectionManager && this.app && tfile) {
+					this.connectionManager.onMeta(tfile, this.cb);
+					const fileCache = this.app.metadataCache.getFileCache(tfile);
 					if (fileCache) {
 						this.updateFromMetadata(fileCache);
 						this.editor.dispatch({

src/observable/ObservableMap.ts

@@ -88,6 +88,7 @@ export class ObservableMap<K, V> extends Observable<ObservableMap<K, V>> {
 		}
 		const derivedMap = new DerivedMap<K, V>(this, predicate);
 		this._derivedMaps.set(predicate, derivedMap);
+		this.unsubscribes.push(derivedMap.destroy);
 		return derivedMap;
 	}
 }

src/ui/Banner.ts

@@ -63,6 +63,7 @@ export class Banner {
 		if (bannerBox) {
 			bannerBox.replaceChildren();
 		}
+		this.onClick = async () => true;
 		return true;
 	}
 }