Skip to content

Commit 3b0ba50

Browse files
committed
Merge branch 'development' into feat-provide-jnml-wrapper
2 parents 650ed42 + c4c5e2c commit 3b0ba50

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
runs-on: ubuntu-latest
2121
strategy:
2222
matrix:
23-
python-version: ["3.9", "3.10", "3.11", "3.12"]
23+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
2424
fail-fast: false
2525

2626
steps:
@@ -36,10 +36,10 @@ jobs:
3636
echo "github.ref is: ${{ github.ref }}"
3737
echo "github.base_ref is: ${{ github.base_ref }}"
3838
39+
3940
- name: Upgrade pip, install deps
4041
run: |
4142
python -m pip install --upgrade pip
42-
pip install 'numpy<2.0.0' # due to lingering issues with other modules
4343
pip install .[dev]
4444
4545
- name: List packages so far

pyneuroml/plot/PlotMorphologyVispy.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1699,6 +1699,8 @@ def create_mesh(
16991699
k = numpy.cross(orig_vec, dir_vector)
17001700
mag_k = numpy.linalg.norm(k)
17011701

1702+
vertices = seg_mesh.get_vertices()
1703+
17021704
if mag_k != 0.0:
17031705
k = k / mag_k
17041706
theta = math.acos(
@@ -1708,13 +1710,11 @@ def create_mesh(
17081710
logger.debug(f"k is {k}, theta is {theta}")
17091711
rot_matrix = rotate(math.degrees(theta), k).T
17101712
rot_obj = Rotation.from_matrix(rot_matrix[:3, :3])
1713+
rotated_vertices = rot_obj.apply(vertices)
17111714
else:
1712-
logger.debug("k is [0..], using zeros for rotation matrix")
1713-
rot_matrix = numpy.zeros((3, 3))
1714-
rot_obj = Rotation.from_matrix(rot_matrix)
1715+
logger.debug("k is [0..], skipping rotation")
1716+
rotated_vertices = vertices
17151717

1716-
vertices = seg_mesh.get_vertices()
1717-
rotated_vertices = rot_obj.apply(vertices)
17181718
translator = numpy.array(
17191719
[offset[0] + prox.x, offset[1] + prox.y, offset[2] + prox.z]
17201720
)

setup.cfg

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ classifiers=
1717
Programming Language :: Python :: 3.10
1818
Programming Language :: Python :: 3.11
1919
Programming Language :: Python :: 3.12
20+
Programming Language :: Python :: 3.13
2021
Topic :: Scientific/Engineering
2122

2223
[options]

0 commit comments

Comments
 (0)