Ensure the model's parsing works properly with the locale #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegonieto
force-pushed
the
json-parse-add-setlocate
branch
4 times, most recently
from
eb03b8a to
aa47ce8
Compare
Author
|
Hi @kylophone , do you think it is possible to have a review of this one? |
use setlocale to ensure parsing model properly. The issue is that json_get_number() does not parser properly the values. This is following the same approach it is done in: https://github.com/Netflix/vmaf/blob/master/libvmaf/src/svm.cpp#L2652-L2660
diegonieto
force-pushed
the
json-parse-add-setlocate
branch
from
febb785 to
9ede68e
Compare
diegonieto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the model's parsing works properly
read_json_model.c: fix issue with json_get_number()
use setlocale to ensure parsing model properly. The issue is that
json_get_number()does not parse properly the values.This is following the same approach it is done in: https://github.com/Netflix/vmaf/blob/master/libvmaf/src/svm.cpp#L2652-L2660
The root cause was the
slopeandinterceptvalues read from the model were not correct. It was reading the model with ",", instead of "." for the numeric values.