Add TestRandom.ProcessResultWithRandomExitCode()

Author: NeilJustice

QuickVsix/CSharpUtils/Process/ProcessResult.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Diagnostics;
+using System.Diagnostics;
 
 namespace CSharpUtils
 {

QuickVsixTests/CSharpUtils/Process/ProcessResultTests.cs

@@ -1,7 +1,5 @@
 using CSharpUtils;
 using NUnit.Framework;
-using System;
-using System.Diagnostics.CodeAnalysis;
 
 [TestFixture]
 public static class ProcessResultTests
@@ -35,8 +33,8 @@ public static void Duration_ReturnsEndTimeMinusStartTime()
    [Test]
    public static void Equals_ThrowsIfAnyFieldNotEqual_OtherwiseReturnsTrue()
    {
-      ProcessResult expected = TestRandom.ProcessResultWithExitCode(TestRandom.Int());
-      ProcessResult actual = TestRandom.ProcessResultWithExitCode(TestRandom.Int());
+      ProcessResult expected = TestRandom.ProcessResultWithRandomExitCode();
+      ProcessResult actual = TestRandom.ProcessResultWithRandomExitCode();
       Assert2.EqualsThrowsInvalidCastExceptionWhenComparedWithANewObject(expected);
 
       NUnitAsserter nunitAsserterMock = Mock.Strict<NUnitAsserter>();

QuickVsixTests/CSharpUtils/UnitTesting/TestRandom.cs

@@ -1,9 +1,6 @@
-using System;
-using System.Collections.Generic;
-using System.Collections.ObjectModel;
+using System.Collections.ObjectModel;
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
-using System.Linq;
 
 namespace CSharpUtils
 {
@@ -192,6 +189,12 @@ public static string[] StringArray()
          return randomStringArray;
       }
 
+      public static ProcessResult ProcessResultWithRandomExitCode()
+      {
+         int randomExitCode = TestRandom.Int();
+         return TestableProcessResultWithExitCode(randomExitCode, RandomGenerator.Instance);
+      }
+
       public static ProcessResult ProcessResultWithExitCode(int exitCode)
       {
          return TestableProcessResultWithExitCode(exitCode, RandomGenerator.Instance);

QuickVsixTests/CSharpUtils/UnitTesting/TestRandomTests.cs

@@ -1,12 +1,9 @@
-using CSharpUtils;
-using NUnit.Framework;
-using System;
-using System.Collections.Generic;
-using System.Collections.ObjectModel;
+using System.Collections.ObjectModel;
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
-using System.Linq;
 using System.Text.RegularExpressions;
+using CSharpUtils;
+using NUnit.Framework;
 
 struct UserType
 {
@@ -300,7 +297,7 @@ public static void StringArray_ReturnsAStringArrayWithLengthBetween0And2Populate
    }
 
    [Test]
-   public static void ProcessResultWithExitCode_ReturnsNewProcessResultWithAllRandomFields()
+   public static void TestableProcessResultWithExitCode_DoesSo()
    {
       var randomGeneratorMock = Mock.Strict<RandomGenerator>();
       string fileName = TestRandom.String();