Rename CSharpUtils.Reflect.Get to CSharpUtils.Reflect.ObjectGet to work around an apparent bug in the Jenkins code coverage plugin related to method overloading

Author: NeilJustice

QuickVsix/CSharpUtils/Reflection/Reflect.cs

@@ -18,7 +18,7 @@ public static FieldInfo GetFieldInfo(Type type, string fieldName)
          return instanceField;
       }
 
-      public static object Get(object obj, string fieldName)
+      public static object ObjectGet(object obj, string fieldName)
       {
          Type objectType = obj.GetType();
          FieldInfo instanceField = GetFieldInfo(objectType, fieldName);
@@ -29,7 +29,7 @@ public static object Get(object obj, string fieldName)
 
       public static T Get<T>(object obj, string fieldName)
       {
-         T instanceField = (T)Get(obj, fieldName);
+         T instanceField = (T)ObjectGet(obj, fieldName);
          return instanceField;
       }
 

QuickVsixTests/CSharpUtils/Reflection/ReflectTests.cs

@@ -46,12 +46,12 @@ public static void GetAndSet_GetsAndSetInstanceFields_ThrowsIfFieldsNotFoundOrNo
    {
       var x = new X();
 
-      Assert.AreEqual(0, Reflect.Get(x, "x"));
-      Assert2.Throws<ArgumentException>(() => Reflect.Get(x, "x123"),
+      Assert.AreEqual(0, Reflect.ObjectGet(x, "x"));
+      Assert2.Throws<ArgumentException>(() => Reflect.ObjectGet(x, "x123"),
           "Field not found: ReflectTests+X.x123");
 
       Reflect.Set(x, "x", 10);
-      Assert.AreEqual(10, Reflect.Get(x, "x"));
+      Assert.AreEqual(10, Reflect.ObjectGet(x, "x"));
       Assert2.Throws<ArgumentException>(() => Reflect.Set(x, "x123", 10),
           "Field not found: ReflectTests+X.x123");
       Assert2.Throws<ArgumentException>(() => Reflect.Set(x, "x", "not_an_int"),

QuickVsixTests/CSharpUtils/UnitTesting/Assert2.cs

@@ -104,7 +104,7 @@ public static void EqualsThrowsInvalidCastExceptionWhenComparedWithANewObject_No
 
       public static void FieldIsNull(object obj, string fieldName)
       {
-         object field = Reflect.Get(obj, fieldName);
+         object field = Reflect.ObjectGet(obj, fieldName);
          Assert.IsNull(field, "Regarding field \"" + fieldName + "\"");
       }