Merge pull request #134 from staminajim/seed-computation-fix

Nebukam · web-flow · commit 9d60f40fc31d · 2025-09-02T08:20:49.000-04:00
Use Unreal's PCG seed functions instead of using Perlin Noise
diff --git a/Source/PCGExtendedToolkit/Private/PCGExRandom.cpp b/Source/PCGExtendedToolkit/Private/PCGExRandom.cpp
@@ -6,6 +6,7 @@
 #include "PCGComponent.h"
 #include "PCGExMath.h"
 #include "PCGSettings.h"
+#include "Helpers/PCGHelpers.h"
 
 namespace PCGExRandom
 {
@@ -60,9 +61,8 @@ namespace PCGExRandom
 	}
 
 	int ComputeSpatialSeed(const FVector& Origin, const FVector& Offset)
-	{
-		return static_cast<int>(PCGExMath::Remap(
-			FMath::PerlinNoise3D(PCGExMath::Tile(Origin * 0.001 + Offset, FVector(-1), FVector(1))),
-			-1, 1, MIN_int32, MAX_int32));
+	{		
+		return PCGHelpers::ComputeSeed(PCGHelpers::ComputeSeedFromPosition(Origin), 
+									   PCGHelpers::ComputeSeedFromPosition(Offset));
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`	`#include "PCGComponent.h"`
`7`	`7`	`#include "PCGExMath.h"`
`8`	`8`	`#include "PCGSettings.h"`
	`9`	`+#include "Helpers/PCGHelpers.h"`
`9`	`10`
`10`	`11`	`namespace PCGExRandom`
`11`	`12`	`{`
`@@ -60,9 +61,8 @@ namespace PCGExRandom`
`60`	`61`	`}`
`61`	`62`
`62`	`63`	`int ComputeSpatialSeed(const FVector& Origin, const FVector& Offset)`
`63`		`- {`
`64`		`- return static_cast<int>(PCGExMath::Remap(`
`65`		`- FMath::PerlinNoise3D(PCGExMath::Tile(Origin * 0.001 + Offset, FVector(-1), FVector(1))),`
`66`		`- -1, 1, MIN_int32, MAX_int32));`
	`64`	`+ {`
	`65`	`+ return PCGHelpers::ComputeSeed(PCGHelpers::ComputeSeedFromPosition(Origin),`
	`66`	`+ PCGHelpers::ComputeSeedFromPosition(Offset));`
`67`	`67`	`}`
`68`	`68`	`}`