From 13e9338dfd2987a21378897f5170bc90c2a62a28 Mon Sep 17 00:00:00 2001 From: Daniel Thom Date: Sun, 3 May 2026 18:02:03 -0600 Subject: [PATCH] Remove dead workflows_with_failures branch in transport_update_workflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit After #300 made is_archived read-only on update_workflow, this branch can never fire — body.is_archived is documented and emitted as readOnly, so any client value is silently ignored, and update_workflow no longer mutates the column. The cleanup is now reachable via transport_archive_workflow, which is the only path that can set is_archived = true. Co-Authored-By: Claude Opus 4.7 --- src/server/http_server/workflows_transport.rs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/server/http_server/workflows_transport.rs b/src/server/http_server/workflows_transport.rs index 8a10bb70..b7cb240e 100644 --- a/src/server/http_server/workflows_transport.rs +++ b/src/server/http_server/workflows_transport.rs @@ -414,11 +414,6 @@ where context: &C, ) -> Result { authorize_workflow!(self, id, context, UpdateWorkflowResponse); - if body.is_archived == Some(true) - && let Ok(mut set) = self.workflows_with_failures.write() - { - set.remove(&id); - } self.workflows_api.update_workflow(id, body, context).await }