feat: add support for NVLink domain discovery in NetQ provider

Signed-off-by: Dmitry Shmulevich <[email protected]>

Author: dmitsh

pkg/providers/netq/netq.go

@@ -25,7 +25,7 @@ import (
 const (
 	LoginURL    = "auth/v1/login"
 	OpIdURL     = "auth/v1/select/opid"
-	TopologyURL = "telemetry/v1/object/topologygraph/fetch-topology"
+	TopologyURL = "api/netq/telemetry/v1/object/topologygraph/fetch-topology"
 )
 
 type NetqResponse struct {

pkg/providers/netq/netq_test.go

@@ -163,9 +163,9 @@ func TestGetURL(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			u, err := getURL(tc.baseURL, tc.query, tc.paths...)
 			if len(tc.err) != 0 {
+				require.NotNil(t, err)
 				require.EqualError(t, err, tc.err)
 			} else {
-
 				require.Nil(t, err)
 				require.Equal(t, tc.url, u)
 			}

pkg/providers/netq/nmx.go

@@ -0,0 +1,70 @@
+/*
+ * Copyright 2025 NVIDIA CORPORATION
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package netq
+
+import (
+	"context"
+	"encoding/base64"
+	"encoding/json"
+	"fmt"
+	"net/http"
+
+	"k8s.io/klog/v2"
+
+	"github.com/NVIDIA/topograph/internal/httperr"
+	"github.com/NVIDIA/topograph/internal/httpreq"
+	"github.com/NVIDIA/topograph/pkg/topology"
+)
+
+const (
+	ComputeURL = "nmx/v1/compute-nodes"
+)
+
+type ComputeNode struct {
+	Id         string `json:"ID"`
+	Name       string `json:"Name"`
+	DomainUUID string `json:"DomainUUID"`
+}
+
+func (p *Provider) getComputeNodes(ctx context.Context) (topology.DomainMap, *httperr.Error) {
+	url, headers, httpErr := p.getComputeUrl()
+	if httpErr != nil {
+		return nil, httpErr
+	}
+
+	klog.V(4).Infof("Fetching %s", url)
+	f := getRequestFunc(ctx, "GET", url, headers, nil)
+	resp, data, err := httpreq.DoRequest(f)
+	if err != nil {
+		return nil, httperr.NewError(resp.StatusCode, err.Error())
+	}
+
+	return parseComputeNodes(data)
+}
+
+func (p *Provider) getComputeUrl() (string, map[string]string, *httperr.Error) {
+	auth := p.cred.user + ":" + p.cred.passwd
+	authHeader := "Basic " + base64.StdEncoding.EncodeToString([]byte(auth))
+	headers := map[string]string{"Authorization": authHeader}
+
+	url, err := getURL(p.params.ApiURL, nil, ComputeURL)
+	return url, headers, err
+}
+
+func parseComputeNodes(data []byte) (topology.DomainMap, *httperr.Error) {
+	var computeNodes []ComputeNode
+	err := json.Unmarshal(data, &computeNodes)
+	if err != nil {
+		return nil, httperr.NewError(http.StatusBadGateway, fmt.Sprintf("nmx output read failed: %v", err))
+	}
+
+	domainMap := topology.NewDomainMap()
+	for _, node := range computeNodes {
+		domainMap.AddHost(node.DomainUUID, node.Name, node.Name)
+	}
+
+	return domainMap, nil
+}

pkg/providers/netq/nmx_test.go

@@ -0,0 +1,69 @@
+/*
+ * Copyright 2025 NVIDIA CORPORATION
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package netq
+
+import (
+	"os"
+	"testing"
+
+	"github.com/NVIDIA/topograph/pkg/topology"
+	"github.com/stretchr/testify/require"
+)
+
+func TestGetComputeUrl(t *testing.T) {
+	p := &Provider{
+		params: &ProviderParams{},
+		cred:   &Credentials{user: "user", passwd: "passwd"},
+	}
+
+	testCases := []struct {
+		name       string
+		serverURL  string
+		headers    map[string]string
+		computeUrl string
+		err        string
+	}{
+		{
+			name:      "Case 1: invalid URL",
+			serverURL: `:///server`,
+			err:       `parse ":///server": missing protocol scheme`,
+		},
+		{
+			name:       "Case 2: valid input",
+			serverURL:  `https://server.com`,
+			headers:    map[string]string{"Authorization": "Basic dXNlcjpwYXNzd2Q="},
+			computeUrl: `https://server.com/nmx/v1/compute-nodes`,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			p.params.ApiURL = tc.serverURL
+			url, headers, err := p.getComputeUrl()
+			if len(tc.err) != 0 {
+				require.NotNil(t, err)
+				require.EqualError(t, err, tc.err)
+			} else {
+				require.Nil(t, err)
+				require.Equal(t, tc.computeUrl, url)
+				require.Equal(t, tc.headers, headers)
+			}
+		})
+	}
+}
+
+func TestParseComputeNodes(t *testing.T) {
+	data, err := os.ReadFile("../../../tests/output/netq/computeNodes.json")
+	require.NoError(t, err)
+
+	domains, err := parseComputeNodes(data)
+	require.Nil(t, err)
+
+	expected := topology.NewDomainMap()
+	expected.AddHost("5e273675-31ef-4aec-a818-969207e0fdef", "", "")
+
+	require.Equal(t, expected, domains)
+}