fix(agent): chdir to / and make env var setting more robust for host machine #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stroless Redo how environment variables are handled and move it all the to chroot_exec script. Precedence order is now skyhook specific > chroot env > container env This way we should capture anything the user sets and use the proper env vars for chroot
lockwobr
approved these changes
Jul 28, 2025
Collaborator
|
@ayuskauskas can this be merged? or is there a reason we are waiting too? |
ayuskauskas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is the addition of
os.chdir("/")the environment stuff is also better as well.Redo how environment variables are handled and move it all the to chroot_exec script. Precedence order is now skyhook specific > chroot env > container env
This way we should capture anything the user sets and use the proper env vars for chroot