fix: reviews

Author: ayuskauskas

chart/templates/skyhook-crd.yaml

@@ -477,7 +477,7 @@ spec:
                 description: Priority determines the order in which skyhooks are applied. Lower values are applied first.
                 type: integer
                 minimum: 0
-                default: 0
+                default: 200
               serial:
                 default: false
                 description: Serial tells skyhook if it allowed to run in parallel or

docs/ordering_of_skyhooks.md

@@ -2,7 +2,7 @@
 ## What
 With v0.8.0 Skyhooks now always get applied in a repeatable and specific order. This also means that all Skyhooks will now be sequential, though packages within a Skyhook can be parallel. Each custom resource now supports a `priority` field which is a non-zero positive integer. Skyhooks will be processed in order starting from 0, any Skyhooks with the same `priority` will be processed by sorting them by their `metadata.name` field.
 
-**NOTE**: Any Skyhook which does NOT provide a `priority` field will be assigned a priority value of 0.
+**NOTE**: Any Skyhook which does NOT provide a `priority` field will be assigned a priority value of 200.
 
 Two additional flow control features have been added with this and can be set in the annotations of each skyhook:
  * `skyhook.nvidia.com/disable`: bool. When `true` it will skip this Skyhook from processing and continue with any other ones further down the priority order.

examples/simple/scr.yaml

@@ -29,16 +29,19 @@ metadata:
     skyhook.nvidia.com/pause: "false"
     skyhook.nvidia.com/disable: "false"
 spec:
+  nodeSelectors:
+    matchLabels:
+      skyhook.nvidia.com/test-node: skyhooke2e
   packages:
     baz:
       version: 1.1.0
       image: ghcr.io/nvidia/skyhook-packages/shellscript
       configMap:
         config.yaml: |-
           #!/bin/bash
-          sleep 30
+          sleep 1
           echo "Hello, config!"
         config_check.yaml: |-
           #!/bin/bash
-          sleep 30
+          sleep 1
           echo "Hello, config check!"

k8s-tests/chainsaw/skyhook/cleanup-pods/chainsaw-test.yaml

@@ -24,7 +24,6 @@ kind: Test
 metadata:
   name: cleanup-pods
 spec:
-  concurrent: false 
   description: |
     This test runs a simple skyhook with dependsOn. We wait tell completed, then trigger update to force config cycle on package B. Once config
     is complete, we update again to make the package error, and at the same clear out the node annotation to trigger cleanup.

k8s-tests/chainsaw/skyhook/config-skyhook/chainsaw-test.yaml

@@ -31,7 +31,6 @@ spec:
     accordingly but the package with the config changes may be skipeed and hang, and this asserts that it doesn't hang in that condition. Then once that completes the same two
     packages have the key with a config interrupt changed and it's asserted that the config, interrupt, and post-interrupt runs for both those packages. Then once that completes 
     again it does one more update on a key for the same two packages which doesn't have a config interrupt defined and makes sure that the config steps are ran for that.
-  concurrent: false
   timeouts:
     assert: 360s
   catch: ## if errors, print the most important info

k8s-tests/chainsaw/skyhook/config-skyhook/skyhook.yaml

@@ -38,6 +38,9 @@ spec:
       interrupt: 
         type: service
         services: [cron]
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -47,6 +50,9 @@ spec:
         game.properties:
           type: service
           services: [rsyslog]
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
       configMap:
         game.properties: |
           enemies=aliens
@@ -65,6 +71,9 @@ spec:
         game.properties:
           type: service
           services: [rsyslog, cron]
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
       configMap:  
         game.properties: |
           enemies=aliens

k8s-tests/chainsaw/skyhook/config-skyhook/update-no-interrupt.yaml

@@ -38,6 +38,9 @@ spec:
       interrupt: 
         type: service
         services: [cron]
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -47,6 +50,9 @@ spec:
         game.properties:
           type: service
           services: [rsyslog]
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
       configMap:
         game.properties: |
           changed
@@ -59,6 +65,9 @@ spec:
         game.properties:
           type: service
           services: [rsyslog, cron]
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
       configMap:  
         game.properties: |
           changed again

k8s-tests/chainsaw/skyhook/config-skyhook/update-while-running.yaml

@@ -38,6 +38,9 @@ spec:
       interrupt: 
         type: service
         services: [cron]
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -47,6 +50,9 @@ spec:
         game.properties:
           type: service
           services: [rsyslog]
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
       configMap:
         game.properties: |
           enemies=aliens
@@ -61,6 +67,9 @@ spec:
     baxter:
       version: "3.2.1"
       image: ghcr.io/nvidia/skyhook/agentless
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
       configInterrupts:
         game.properties:
           type: service

k8s-tests/chainsaw/skyhook/config-skyhook/update.yaml

@@ -38,6 +38,9 @@ spec:
       interrupt: 
         type: service
         services: [cron]
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -47,6 +50,9 @@ spec:
         game.properties:
           type: service
           services: [rsyslog]
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
       configMap:
         game.properties: |
           changed
@@ -62,6 +68,9 @@ spec:
         game.properties:
           type: service
           services: [rsyslog, cron]
+      env: 
+        - name: SLEEP_LEN
+          value: "1"
       configMap:  
         game.properties: |
           changed again

k8s-tests/chainsaw/skyhook/depends-on/chainsaw-test.yaml

@@ -24,7 +24,6 @@ kind: Test
 metadata:
   name: depends-on
 spec:
-  concurrent: false 
   description: |
     Test makes sure depends-on works as expected. c depends on a, and b. Make sure a and b complete before c starts.
   timeouts: