fix: update tests to not set limits everywhere anymore

Author: lockwobr

chart/templates/skyhook-crd.yaml

@@ -383,7 +383,6 @@ spec:
                       pattern: ^[a-z][-a-z0-9]{0,41}[a-z]$
                       type: string
                     resources:
-                      default: {}
                       description: |-
                         Resources lets you set the cpu and memory limits and requests for this package.
                         More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
@@ -392,28 +391,24 @@ spec:
                           anyOf:
                           - type: integer
                           - type: string
-                          default: 500m
                           pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                           x-kubernetes-int-or-string: true
                         cpuRequest:
                           anyOf:
                           - type: integer
                           - type: string
-                          default: 500m
                           pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                           x-kubernetes-int-or-string: true
                         memoryLimit:
                           anyOf:
                           - type: integer
                           - type: string
-                          default: 256Mi
                           pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                           x-kubernetes-int-or-string: true
                         memoryRequest:
                           anyOf:
                           - type: integer
                           - type: string
-                          default: 256Mi
                           pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                           x-kubernetes-int-or-string: true
                       type: object

docs/resource_management.md

@@ -108,4 +108,18 @@ If there is **no LimitRange** and you do **not** set resource requests/limits in
 
 ---
 
+## 7. Special Case: Uninstall Pod Resources
+
+Uninstall pods in Skyhook **do not use per-package resource overrides**.  
+Instead, their resource requests/limits are determined only by the namespace defaults:
+
+- If a LimitRange is present in the namespace, uninstall pods will use those default CPU and memory requests/limits.
+- If there is no LimitRange, uninstall pods will run as "BestEffort" (no resource requests/limits).
+- Any `resources:` overrides set for the original package are **not applied** to the uninstall pod.
+
+**Note:**
+- Ensure defaults are big enough for uninstall processes if using the uninstall package life cycle.
+
+---
+
 For more information, see the [Kubernetes documentation on resource management](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/) and [LimitRange](https://kubernetes.io/docs/concepts/policy/limit-range/). 

k8s-tests/chainsaw/skyhook/cleanup-pods/force-config.yaml

@@ -37,11 +37,6 @@ spec:
       env: 
         - name: SLEEP_LEN
           value: "3" 
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     bb:
       version: "1.2"
       gracefulShutdown: 46s
@@ -51,10 +46,5 @@ spec:
       env: 
         - name: SLEEP_LEN
           value: "2"
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
       configMap:
         foo: buz

k8s-tests/chainsaw/skyhook/cleanup-pods/muck_up.yaml

@@ -37,11 +37,6 @@ spec:
       env: 
         - name: SLEEP_LEN
           value: "3"
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     bb:
       version: "1.2"
       gracefulShutdown: 46s
@@ -53,10 +48,5 @@ spec:
           value: "2"
         - name: SLEEP_LEN
           value: "2"
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
       configMap:
         foo: bur

k8s-tests/chainsaw/skyhook/cleanup-pods/setup.yaml

@@ -37,11 +37,6 @@ spec:
       env: 
         - name: SLEEP_LEN
           value: "2"
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     bb:
       version: "1.2"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -50,10 +45,5 @@ spec:
       env: 
         - name: SLEEP_LEN
           value: "2"
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
       configMap:
         foo: bar

k8s-tests/chainsaw/skyhook/config-skyhook/skyhook.yaml

@@ -38,11 +38,6 @@ spec:
       interrupt: 
         type: service
         services: [cron]
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -52,11 +47,6 @@ spec:
         game.properties:
           type: service
           services: [rsyslog]
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
       configMap:
         game.properties: |
           enemies=aliens
@@ -86,8 +76,3 @@ spec:
           color.bad=yellow
           allow.textmode=true
           how.nice.to.look=fairlyNice
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi

k8s-tests/chainsaw/skyhook/config-skyhook/update-no-interrupt.yaml

@@ -38,11 +38,6 @@ spec:
       interrupt: 
         type: service
         services: [cron]
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -57,11 +52,6 @@ spec:
           changed
         ui.properties: |
           changed
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     baxter:
       version: "3.2.1"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -73,9 +63,4 @@ spec:
         game.properties: |
           changed again
         ui.properties: |
-          changed
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
+          changed

k8s-tests/chainsaw/skyhook/config-skyhook/update-while-running.yaml

@@ -38,11 +38,6 @@ spec:
       interrupt: 
         type: service
         services: [cron]
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -63,11 +58,6 @@ spec:
           color.bad=yellow
           allow.textmode=true
           how.nice.to.look=fairlyNice
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     baxter:
       version: "3.2.1"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -82,9 +72,4 @@ spec:
           color.good=purple
           color.bad=yellow
           allow.textmode=true
-          how.nice.to.look=fairlyNice
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
+          how.nice.to.look=fairlyNice

k8s-tests/chainsaw/skyhook/config-skyhook/update.yaml

@@ -38,11 +38,6 @@ spec:
       interrupt: 
         type: service
         services: [cron]
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -60,11 +55,6 @@ spec:
           color.bad=yellow
           allow.textmode=true
           how.nice.to.look=fairlyNice
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     baxter:
       version: "3.2.1"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -79,9 +69,4 @@ spec:
           color.good=purple
           color.bad=yellow
           allow.textmode=true
-          how.nice.to.look=fairlyNice
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
+          how.nice.to.look=fairlyNice

k8s-tests/chainsaw/skyhook/depends-on/skyhook.yaml

@@ -39,22 +39,12 @@ spec:
       env: 
         - name: SLEEP_LEN
           value: "1"
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     bb-slow:
       version: "1.2"
       image: ghcr.io/nvidia/skyhook/agentless
       env: 
         - name: SLEEP_LEN
           value: "10"
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
     cc-last:
       version: "5.4.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -63,9 +53,4 @@ spec:
         bb-slow: "1.2"  
       env: 
         - name: SLEEP_LEN
-          value: "1"
-      resources:
-        cpuLimit: 50m
-        cpuRequest: 50m
-        memoryLimit: 32Mi
-        memoryRequest: 32Mi
+          value: "1"